You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2019/03/08 14:00:27 UTC
[GitHub] [knox] risdenk commented on a change in pull request #65: KNOX-1774
- Introducing environment variables in gateway/knoxcli/ldap/knoxshell
scripts for customization
risdenk commented on a change in pull request #65: KNOX-1774 - Introducing environment variables in gateway/knoxcli/ldap/knoxshell scripts for customization
URL: https://github.com/apache/knox/pull/65#discussion_r263778663
##########
File path: gateway-release-common/home/bin/knox-functions.sh
##########
@@ -17,8 +17,6 @@
# limitations under the License.
#
-ENV_PID_DIR=""
-
JAVA_VERSION_PATTERNS=( "1.6.0_31/bin/java$" "1.6.0_.*/bin/java$" "1.6.0.*/bin/java$" "1.6\..*/bin/java$" "/bin/java$" )
Review comment:
We can remove the 1.6.x versions here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services