You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "yzeng25 (via GitHub)" <gi...@apache.org> on 2023/04/16 13:09:23 UTC
[GitHub] [apisix-website] yzeng25 commented on a diff in pull request #1563: 01vishu/added tags
yzeng25 commented on code in PR #1563:
URL: https://github.com/apache/apisix-website/pull/1563#discussion_r1167920557
##########
blog/en/blog/2022/09/13/why-is-apache-apisix-the-best-api-gateway.md:
##########
@@ -12,7 +12,17 @@ keywords:
- The Best API Gateway
- Apache APISIX
description: Why is Apache APISIX the best API Gateway? We will compare multiple API gateways (Kong, Tyk, Gloo) in terms of the popularity among developers, open source licenses, performances, and the ecosystem as a whole.
-tags: [Technology, Products]
+tags:
+ [
+ Technology,
+ Products,
+ Case Studies,
+ Ecosystem,
+ Authentication,
+ Plugins,
+ Community,
+ Vulnerabilities,
+ ]
Review Comment:
I might have ignored some info in https://github.com/apache/apisix-website/issues/1554. To clarify the issue: choose one or more tags from
- Case Studies
- Ecosystem
- Authentication
- Plugins
- Community
- Vulnerabilities
```suggestion
tags:
tags: [Community]
```
In this case I think `Community` will do.
##########
website/src/components/Video.tsx:
##########
@@ -49,7 +49,10 @@ export const Video: FC<VideoProps> = (props) => {
return (
<div data-vjs-player>
{/* eslint-disable-next-line jsx-a11y/media-has-caption */}
- <video ref={videoRef} className="video-js vjs-big-play-centered" />
+ <video
+ ref={videoRef}
+ className="video-js vjs-big-play-centered video-player"
+ />
Review Comment:
ditto
##########
website/src/css/landing-sections/video.css:
##########
@@ -5,3 +5,9 @@
.video-js.vjs-paused .vjs-big-play-button {
display: inline-block !important;
}
+
+.video-player {
+ aspect-ratio: 16/9;
+ max-width: 100%;
+ height: 100%;
+}
Review Comment:
ditto, please revert.
##########
website/src/components/Video.tsx:
##########
@@ -1,14 +1,14 @@
-import type { FC } from 'react';
-import React from 'react';
-import videojs from 'video.js';
-import type { VideoJsPlayerOptions, VideoJsPlayer } from 'video.js';
-import 'video.js/dist/video-js.min.css';
-import '../css/landing-sections/video.css';
+import type { FC } from "react";
+import React from "react";
+import videojs from "video.js";
+import type { VideoJsPlayerOptions, VideoJsPlayer } from "video.js";
+import "video.js/dist/video-js.min.css";
+import "../css/landing-sections/video.css";
Review Comment:
ditto, please revert.
##########
blog/en/blog/2022/09/13/why-is-apache-apisix-the-best-api-gateway.md:
##########
@@ -12,7 +12,17 @@ keywords:
- The Best API Gateway
- Apache APISIX
description: Why is Apache APISIX the best API Gateway? We will compare multiple API gateways (Kong, Tyk, Gloo) in terms of the popularity among developers, open source licenses, performances, and the ecosystem as a whole.
-tags: [Technology, Products]
+tags:
+ [
+ Technology,
+ Products,
+ Case Studies,
+ Ecosystem,
+ Authentication,
+ Plugins,
+ Community,
+ Vulnerabilities,
+ ]
Review Comment:
Please update `zh/blog/2022/09/27/why-apache-apisix-is-best-apigateway/` file as well.
##########
website/src/components/Video.tsx:
##########
@@ -24,7 +24,7 @@ export const Video: FC<VideoProps> = (props) => {
if (!videoElement) return;
const player = videojs(videoElement, options, () => {
- videojs.log('player is ready');
+ videojs.log("player is ready");
Review Comment:
ditto
##########
blog/en/blog/2022/09/13/why-is-apache-apisix-the-best-api-gateway.md:
##########
@@ -69,9 +79,9 @@ Under such circumstances, choosing an Apache Software Foundation(ASF)'s open sou
A frequently asked question in the community: which one has the better performance, Envoy-based Gloo or NGINX-based APISIX? Although performance is not the most critical metric, it is inarguably the most direct metric. The table below shows the benchmark scores of Apache APISIX and Gloo. The QPS of Apache APISIX is 4.6 times that of Gloo, and the latency of Apache APISIX is merely 7% of Gloo’s.
-| **API Gateway** | Apache APISIX | Gloo Edge |
-| :-------------: | :----------------------------------------------------------------------: | :--------------------------------------------------------------------: |
-| **QPS** | 59122 | 12903 |
+| **API Gateway** | Apache APISIX | Gloo Edge |
+| :-------------: | :-------------------------------------------------------------------------: | :-----------------------------------------------------------------------: |
+| **QPS** | 59122 | 12903 |
Review Comment:
This is out of #1554 's scope, please revert it. I like the attitude though.
##########
website/src/components/Video.tsx:
##########
@@ -1,14 +1,14 @@
-import type { FC } from 'react';
-import React from 'react';
-import videojs from 'video.js';
-import type { VideoJsPlayerOptions, VideoJsPlayer } from 'video.js';
-import 'video.js/dist/video-js.min.css';
-import '../css/landing-sections/video.css';
+import type { FC } from "react";
+import React from "react";
+import videojs from "video.js";
+import type { VideoJsPlayerOptions, VideoJsPlayer } from "video.js";
+import "video.js/dist/video-js.min.css";
+import "../css/landing-sections/video.css";
export interface VideoProps {
- options: VideoJsPlayerOptions,
- // eslint-disable-next-line react/require-default-props
- onReady?: ((player: VideoJsPlayer) => void) | undefined
+ options: VideoJsPlayerOptions;
+ // eslint-disable-next-line react/require-default-props
+ onReady?: ((player: VideoJsPlayer) => void) | undefined;
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org