[GitHub] [spark] squito commented on a change in pull request #23788: [SPARK-27176][SQL] Upgrade hadoop-3's built-in Hive maven dependencies to 2.3.4

[GitBox <gi...@apache.org>]

squito commented on a change in pull request #23788: [SPARK-27176][SQL] Upgrade hadoop-3's built-in Hive maven dependencies to 2.3.4
URL: https://github.com/apache/spark/pull/23788#discussion_r271061531
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
 ##########
 @@ -54,8 +55,11 @@ private[spark] object HiveUtils extends Logging {
     sc
   }
 
+  private val supportedHive2ShortVersions = Set("2.3.0")
+  val isSupportedHive2 = supportedHive2ShortVersions.contains(HiveVersionInfo.getShortVersion)
+
   /** The version of hive used internally by Spark SQL. */
-  val builtinHiveVersion: String = "1.2.1"
+  val builtinHiveVersion: String = if (isSupportedHive2) HiveVersionInfo.getVersion else "1.2.1"
 
 Review comment:
   @srowen this change doesn't remove the dependency on our fork of 1.2.1 -- see
   
   https://github.com/apache/spark/blob/eaf008ad0e6e246665127c283b139a16424f3139/pom.xml#L127-L130
   
   https://github.com/apache/spark/blob/eaf008ad0e6e246665127c283b139a16424f3139/pom.xml#L1384-L1386
   
   Or are you proposing including a bigger change here to do that as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org