You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "DheerajKumar19 (via GitHub)" <gi...@apache.org> on 2023/05/23 02:32:33 UTC
[GitHub] [fineract] DheerajKumar19 opened a new pull request, #3193: Added test cases to test GetNextRecurringDate method in CalendarUtils
DheerajKumar19 opened a new pull request, #3193:
URL: https://github.com/apache/fineract/pull/3193
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] DheerajKumar19 commented on pull request #3193: Added test cases to test GetNextRecurringDate method in CalendarUtils
Posted by "DheerajKumar19 (via GitHub)" <gi...@apache.org>.
DheerajKumar19 commented on PR #3193:
URL: https://github.com/apache/fineract/pull/3193#issuecomment-1594339510
There is no jira ticket linked to this. And I have no access to create a jira ticket. This PR was intended to add a test case for a function which has no test case coverage as a part of our course project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #3193: FINERACT-1724: Added test cases to test GetNextRecurringDate method in CalendarUtils
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3193: FINERACT-1724: Added test cases to test GetNextRecurringDate method in CalendarUtils
URL: https://github.com/apache/fineract/pull/3193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #3193: FINERACT-1724: Added test cases to test GetNextRecurringDate method in CalendarUtils
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics commented on PR #3193:
URL: https://github.com/apache/fineract/pull/3193#issuecomment-1623682491
@DheerajKumar19 please fix the build. As you can see they are failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #3193: Added test cases to test GetNextRecurringDate method in CalendarUtils
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics commented on PR #3193:
URL: https://github.com/apache/fineract/pull/3193#issuecomment-1560817550
@DheerajKumar19 can you pls squash your commits into a single one? Also, add a respective FINERACT JIRA ticket into the PR title and the commit's message as a prefix. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #3193: FINERACT-1724: Added test cases to test GetNextRecurringDate method in CalendarUtils
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #3193:
URL: https://github.com/apache/fineract/pull/3193#issuecomment-1647805502
@DheerajKumar19 please run `checkstyleTest` on to see the problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] DheerajKumar19 commented on pull request #3193: Added test cases to test GetNextRecurringDate method in CalendarUtils
Posted by "DheerajKumar19 (via GitHub)" <gi...@apache.org>.
DheerajKumar19 commented on PR #3193:
URL: https://github.com/apache/fineract/pull/3193#issuecomment-1595312566
@adamsaghy I have resolved all the review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #3193: Added test cases to test GetNextRecurringDate method in CalendarUtils
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #3193:
URL: https://github.com/apache/fineract/pull/3193#issuecomment-1594359360
@DheerajKumar19 You might wanna use FINERACT-1724 then. (minor fixes and upgrades for 1.9 version)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] DheerajKumar19 commented on pull request #3193: Added test cases to test GetNextRecurringDate method in CalendarUtils
Posted by "DheerajKumar19 (via GitHub)" <gi...@apache.org>.
DheerajKumar19 commented on PR #3193:
URL: https://github.com/apache/fineract/pull/3193#issuecomment-1594381994
Thank you will add this as my ticket!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #3193: FINERACT-1724: Added test cases to test GetNextRecurringDate method in CalendarUtils
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3193:
URL: https://github.com/apache/fineract/pull/3193#issuecomment-1690801973
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org