You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/10/08 19:14:39 UTC
[GitHub] [trafficserver] shinrich opened a new pull request #7261: Sticky server does not work with H2 client
shinrich opened a new pull request #7261:
URL: https://github.com/apache/trafficserver/pull/7261
[Step to Reproduce crash]
1. Set the following configurations in records.config.
CONFIG proxy.config.http.attach_server_session_to_client INT 1
CONFIG proxy.config.net.default_inactivity_timeout INT 10
2. Restart ATS
3. Send a GET request with HTTP/2 to ATS that will communicate with an origin server
4. Wait for inactivity timeout, 10 seconds, that was specified by the config of default_inactivity_timeout.
5. Crash
The problem was that the
proxy.config.http.attach_server_session_to_client setting only currently makes sense for HTTP/1. x user agents. As we make our origin connections both HTTP/2 and HTTP/1.x it may make sense to add this sticky session support between HTTP/2 user agent and server sessions.
This fix avoids setting the sticky server session if the user agent is HTTP2. It will instead just close the server session. So the server session so not left floating around with a reference to the deleted HttpSM..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7261: Sticky server does not work with H2 client
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7261:
URL: https://github.com/apache/trafficserver/pull/7261#issuecomment-715414462
Cherry-picked to v9.0.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall removed a comment on pull request #7261: Sticky server does not work with H2 client
Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #7261:
URL: https://github.com/apache/trafficserver/pull/7261#issuecomment-705868652
[approve ci clang-format]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] yknoya commented on pull request #7261: Sticky server does not work with H2 client
Posted by GitBox <gi...@apache.org>.
yknoya commented on pull request #7261:
URL: https://github.com/apache/trafficserver/pull/7261#issuecomment-716931489
@masaori335 Sorry, I don't have it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7261: Sticky server does not work with H2 client
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7261:
URL: https://github.com/apache/trafficserver/pull/7261#issuecomment-705868652
[approve ci clang-format]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7261: Sticky server does not work with H2 client
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7261:
URL: https://github.com/apache/trafficserver/pull/7261#issuecomment-716699773
@masaori335 This has some pretty serious merge conflicts for 8.1.x, I think we'l need a new branch PR for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7261: Sticky server does not work with H2 client
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7261:
URL: https://github.com/apache/trafficserver/pull/7261#issuecomment-705868652
[approve ci clang-format]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #7261: Sticky server does not work with H2 client
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #7261:
URL: https://github.com/apache/trafficserver/pull/7261#issuecomment-716861694
@shinrich @yknoya Do you have a patch for 8.1.x?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich merged pull request #7261: Sticky server does not work with H2 client
Posted by GitBox <gi...@apache.org>.
shinrich merged pull request #7261:
URL: https://github.com/apache/trafficserver/pull/7261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org