You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/01/24 05:49:08 UTC

[GitHub] [rocketmq] XiaoyiPeng opened a new issue #3786: The length of properties value should be checked before converting them to short.

XiaoyiPeng opened a new issue #3786:
URL: https://github.com/apache/rocketmq/issues/3786


   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   https://github.com/apache/rocketmq/blob/35334e266984c4a3ee6179ffd44bb37372788696/common/src/main/java/org/apache/rocketmq/common/message/MessageDecoder.java#L162
   
   The length of properties value should be checked before converting it to short, **otherwise this value is negative !**
   
   https://github.com/apache/rocketmq/blob/35334e266984c4a3ee6179ffd44bb37372788696/store/src/main/java/org/apache/rocketmq/store/CommitLog.java#L1609
   
   The length of properties value should be checked before converting them to short when encode `MessageExtBatch`. 
   The class `CommitLog` **only check** length of properties value when call encode() method for `MessageExtBrokerInner`.
   
   
   If not do this (check length of properties value), the error message will not be ambiguous, as shown below: 
   
   ![image](https://user-images.githubusercontent.com/8653312/150728543-e6291189-7ce9-4e95-a370-fd3394073396.png)
   
   
   
   2. Please tell us about your environment:
   
       OS: Windows 10
       branch: develop


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky closed issue #3786: The length of properties value should be checked before converting them to short.

Posted by GitBox <gi...@apache.org>.

duhenglucky closed issue #3786:
URL: https://github.com/apache/rocketmq/issues/3786


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org