Re: [jclouds/jclouds-labs] JCLOUDS-1124 oneandone-server-api (#275)

[Ignasi Barrera <no...@github.com>]

Thanks for the contribution @alibazlamit!

Before we start a detailed review of the code, I think we should try to address some design. Having a quick look, it seems this PR is inspired by the ProfitBricks rest one, but I'm not sure that is the best approach given the nature of the one and one api.

Most of the code in this pull request are just request binders, but as far as I see the 1&1 api, its model classes are pretty straightforward and we could easily map all them to plain AutoValue model classes, and get the jclouds default json binders just serialize and deserialize everything without the need for custom binders. Is there an special need to justify all the amount of code (and maintenance overhead) that having a specific binder for each request would introduce?

It is really important to have the simpler implementation possible, and I'd strongly suggest you refactor the model to uso AutoValue to directly map the 1&1 json model, and let jclouds default binders take care of serialization.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/275#issuecomment-224406735