You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/07 06:31:34 UTC
[GitHub] [pulsar] codelipenghui commented on a change in pull request #14569: [Broker] Full-support ssl provider, ciphers and protocols for broker service and proxy service
codelipenghui commented on a change in pull request #14569:
URL: https://github.com/apache/pulsar/pull/14569#discussion_r820412517
##########
File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ServiceChannelInitializer.java
##########
@@ -64,7 +65,7 @@ public ServiceChannelInitializer(ProxyService proxyService, ProxyConfiguration s
if (enableTls) {
if (tlsEnabledWithKeyStore) {
serverSSLContextAutoRefreshBuilder = new NettySSLContextAutoRefreshBuilder(
- serviceConfig.getTlsProvider(),
+ serviceConfig.getServiceSslProvider(),
Review comment:
Why not to use `tlsProvider`?
##########
File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ServiceChannelInitializer.java
##########
@@ -64,7 +65,7 @@ public ServiceChannelInitializer(ProxyService proxyService, ProxyConfiguration s
if (enableTls) {
if (tlsEnabledWithKeyStore) {
serverSSLContextAutoRefreshBuilder = new NettySSLContextAutoRefreshBuilder(
- serviceConfig.getTlsProvider(),
+ serviceConfig.getServiceSslProvider(),
Review comment:
And the webservice, websocket also use the `tlsProvider` as `sslProviderString` for `JettySslContextFactoryWithAutoRefresh`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org