You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/31 23:42:22 UTC

[GitHub] [spark] viirya commented on a change in pull request #26330: [WIP][SPARK-29672][PYSPARK] DO NOT MERGE -- remove py27 support for jenkins tests

viirya commented on a change in pull request #26330: [WIP][SPARK-29672][PYSPARK] DO NOT MERGE -- remove py27 support for jenkins tests
URL: https://github.com/apache/spark/pull/26330#discussion_r341407750
 
 

 ##########
 File path: python/run-tests.py
 ##########
 @@ -160,11 +160,15 @@ def run_individual_python_test(target_dir, test_name, pyspark_python):
 
 
 def get_default_python_executables():
-    python_execs = [x for x in ["python2.7", "python3.6", "pypy"] if which(x)]
-    if "python2.7" not in python_execs:
-        LOGGER.warning("Not testing against `python2.7` because it could not be found; falling"
-                       " back to `python` instead")
-        python_execs.insert(0, "python")
+    python_execs = [x for x in ["python3.6", "pypy3"] if which(x)]
+    if "python3.6" not in python_execs:
+        if which("python"):
+            LOGGER.warning("Not testing against `python3.6` because it could not be found; falling"
+                           " back to `python` instead")
+            python_execs.insert(0, "python")
 
 Review comment:
   Can this fall back to python 2 actually?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org