You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/09/16 17:00:41 UTC
[GitHub] [activemq-artemis] gtully opened a new pull request #3265: ARTEMIS-2888 - ensure the pageStore uses the publish address rather t…
gtully opened a new pull request #3265:
URL: https://github.com/apache/activemq-artemis/pull/3265
…han the subscriptions value which may have a wildcard
There is still something odd, the test works however I see an unexpected WARN:
[Thread-2 (activemq-netty-threads)] 17:54:02,694 WARN [org.apache.activemq.artemis.core.server] AMQ222038: Starting paging on address 'A.*'; size is currently: 1,025 bytes; max-size-bytes: 50; global-size-bytes: 1,025
note the address is A.*!
I think that is wrong. more investigation needed. maybe folks more familiar will see what is going on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully commented on pull request #3265: ARTEMIS-2888 - ensure the pageStore uses the publish address rather t…
Posted by GitBox <gi...@apache.org>.
gtully commented on pull request #3265:
URL: https://github.com/apache/activemq-artemis/pull/3265#issuecomment-698205974
@jbertram thanks, that is a nice test. pulled it in and proves the point that this new page-store-name setting is needed even if paging does not kick in because the dispatch is always through cursors. updated the doc to reflect that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3265: ARTEMIS-2888 - ensure the pageStore uses the publish address rather t…
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3265:
URL: https://github.com/apache/activemq-artemis/pull/3265#issuecomment-698048870
@gtully, can you grab the tests from #3238 and add them here? Other than that it looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully merged pull request #3265: ARTEMIS-2888 - ensure the pageStore uses the publish address rather t…
Posted by GitBox <gi...@apache.org>.
gtully merged pull request #3265:
URL: https://github.com/apache/activemq-artemis/pull/3265
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3265: ARTEMIS-2888 - ensure the pageStore uses the publish address rather t…
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3265:
URL: https://github.com/apache/activemq-artemis/pull/3265#issuecomment-693754690
lets talk about this when you can?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully merged pull request #3265: ARTEMIS-2888 - ensure the pageStore uses the publish address rather t…
Posted by GitBox <gi...@apache.org>.
gtully merged pull request #3265:
URL: https://github.com/apache/activemq-artemis/pull/3265
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully commented on pull request #3265: ARTEMIS-2888 - ensure the pageStore uses the publish address rather t…
Posted by GitBox <gi...@apache.org>.
gtully commented on pull request #3265:
URL: https://github.com/apache/activemq-artemis/pull/3265#issuecomment-698205974
@jbertram thanks, that is a nice test. pulled it in and proves the point that this new page-store-name setting is needed even if paging does not kick in because the dispatch is always through cursors. updated the doc to reflect that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully commented on pull request #3265: ARTEMIS-2888 - ensure the pageStore uses the publish address rather t…
Posted by GitBox <gi...@apache.org>.
gtully commented on pull request #3265:
URL: https://github.com/apache/activemq-artemis/pull/3265#issuecomment-694075294
sure, there is also a test failure that I will investigate: org.apache.activemq.artemis.core.protocol.mqtt.MQTTRetainMessageManagerTest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3265: ARTEMIS-2888 - ensure the pageStore uses the publish address rather t…
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3265:
URL: https://github.com/apache/activemq-artemis/pull/3265#issuecomment-695075874
I'm pretty sure this is related to both [ARTEMIS-2859](https://issues.apache.org/jira/browse/ARTEMIS-2768) and [ARTEMIS-2768](https://issues.apache.org/jira/browse/ARTEMIS-2768) as the size of the page-store underneath the address is being manipulated incorrectly when messages are sent & consumed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully commented on pull request #3265: ARTEMIS-2888 - ensure the pageStore uses the publish address rather t…
Posted by GitBox <gi...@apache.org>.
gtully commented on pull request #3265:
URL: https://github.com/apache/activemq-artemis/pull/3265#issuecomment-697695646
@jbertram can you have a quick peek over this to see if i missed anything on the xml attribute addition and doc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3265: ARTEMIS-2888 - ensure the pageStore uses the publish address rather t…
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3265:
URL: https://github.com/apache/activemq-artemis/pull/3265#issuecomment-697936561
this LGTM...
@jbertram since you're reviewing this per Gary's request if you could merge it when done please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org