You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/05 05:40:25 UTC
[GitHub] [spark] mgaido91 commented on issue #25033: [SPARK-28224][SQL]
Aggregate sum large decimals
mgaido91 commented on issue #25033: [SPARK-28224][SQL] Aggregate sum large decimals
URL: https://github.com/apache/spark/pull/25033#issuecomment-508636140
Thanks for your work. Regarding SQLServer, I also checked its behaviour. The main difference with our current behaviour is that it always returns the max precision, instead of our formula 10 + precision. So I submitted a PR for that.
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org