You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/09 12:48:50 UTC
[GitHub] [spark] Yikun commented on a diff in pull request #37437: [SPARK-40006][PYTHON][DOCS] Make pyspark.sql.group examples self-contained
Yikun commented on code in PR #37437:
URL: https://github.com/apache/spark/pull/37437#discussion_r941297621
##########
python/pyspark/sql/group.py:
##########
@@ -261,17 +413,69 @@ def pivot(self, pivot_col: str, values: Optional[List["LiteralType"]] = None) ->
Examples
--------
- # Compute the sum of earnings for each year by course with each course as a separate column
-
- >>> df4.groupBy("year").pivot("course", ["dotNET", "Java"]).sum("earnings").collect()
- [Row(year=2012, dotNET=15000, Java=20000), Row(year=2013, dotNET=48000, Java=30000)]
-
- # Or without specifying column values (less efficient)
-
- >>> df4.groupBy("year").pivot("course").sum("earnings").collect()
- [Row(year=2012, Java=20000, dotNET=15000), Row(year=2013, Java=30000, dotNET=48000)]
- >>> df5.groupBy("sales.year").pivot("sales.course").sum("sales.earnings").collect()
- [Row(year=2012, Java=20000, dotNET=15000), Row(year=2013, Java=30000, dotNET=48000)]
+ >>> from pyspark.sql import Row
+ >>> spark = SparkSession.builder.master("local[4]").appName("sql.group tests").getOrCreate()
Review Comment:
Sorry to post review, just curious why not use the `spark` directly in here? I think this example is a little bit different with others.
For all PRs in this series, I think `sc` (Spark context) and `spark` (SparkSession) can define in the bottom, and use it directly in every doctest (just like pyspark shell, sc and spark already available), right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org