You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/08/30 10:41:26 UTC

[GitHub] [hudi] wangxianghu opened a new pull request #2054: [HUDI-1252] Remove unused class NoOpBulkInsertPartitioner in DataSour…

wangxianghu opened a new pull request #2054:
URL: https://github.com/apache/hudi/pull/2054


   …ceTestUtils
   
   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *Remove unused class NoOpBulkInsertPartitioner in DataSourceTestUtils*
   
   ## Brief change log
   
   DataSourceTestUtils's inner class NoOpBulkInsertPartitioner was not used anywhere, we can remove it.
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan merged pull request #2054: [HUDI-1252] Remove unused code in DataSourceTestUtils

Posted by GitBox <gi...@apache.org>.
xushiyan merged pull request #2054:
URL: https://github.com/apache/hudi/pull/2054


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on pull request #2054: [HUDI-1252] Remove unused class NoOpBulkInsertPartitioner in DataSour…

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #2054:
URL: https://github.com/apache/hudi/pull/2054#issuecomment-683503914


   > Hi @wangxianghu the removal looks good. Good catch!
   > 
   > While you're here, could you also clean up other unused methods in this class? namely
   > 
   > ```
   > org.apache.hudi.testutils.DataSourceTestUtils#convertToString
   > org.apache.hudi.testutils.DataSourceTestUtils#convertToStringList
   > org.apache.hudi.testutils.DataSourceTestUtils#convertKeysToStringList
   > ```
   > 
   > These must have been leftover during a rebase in the past. these methods have been migrated to
   > 
   > ```
   > org.apache.hudi.common.testutils.RawTripTestPayload#recordToString
   > org.apache.hudi.common.testutils.RawTripTestPayload#recordsToStrings
   > ```
   > 
   > and `convertKeysToStringList` merged to
   > https://github.com/apache/hudi/blob/b8f4a30efd8bb6257c926a4b79a092cb96b8aff8/hudi-spark/src/test/java/HoodieJavaApp.java#L197
   
   @xushiyan thanks for your review. I have removed the methods you mentioned, PTAL :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on pull request #2054: [HUDI-1252] Remove unused class NoOpBulkInsertPartitioner in DataSour…

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #2054:
URL: https://github.com/apache/hudi/pull/2054#issuecomment-683406638


   @yanghua @xushiyan  please take a look when free 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on pull request #2054: [HUDI-1252] Remove unused class NoOpBulkInsertPartitioner in DataSour…

Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #2054:
URL: https://github.com/apache/hudi/pull/2054#issuecomment-683448216


   Hi @wangxianghu the removal looks good. Good catch!
   
   While you're here, could you also clean up other unused methods in this class? namely
   ```
   org.apache.hudi.testutils.DataSourceTestUtils#convertToString
   org.apache.hudi.testutils.DataSourceTestUtils#convertToStringList
   org.apache.hudi.testutils.DataSourceTestUtils#convertKeysToStringList
   ```
   
   These must have been leftover during a rebase in the past. these methods have been migrated to
   
   ```
   org.apache.hudi.common.testutils.RawTripTestPayload#recordToString
   org.apache.hudi.common.testutils.RawTripTestPayload#recordsToStrings
   ```
   
   and `convertKeysToStringList` merged to
   https://github.com/apache/hudi/blob/b8f4a30efd8bb6257c926a4b79a092cb96b8aff8/hudi-spark/src/test/java/HoodieJavaApp.java#L197


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org