You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "CodingSinger (GitHub)" <gi...@apache.org> on 2020/03/04 10:22:39 UTC

[GitHub] [dubbo-go] CodingSinger opened pull request #389: add healthcheck router



[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #389: add healthcheck router

Posted by "zouyx (GitHub)" <gi...@apache.org>.
```c.OutStandingRequestConutLimit```  Use getter for get value.

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #389: add healthcheck router

Posted by "zouyx (GitHub)" <gi...@apache.org>.
apache license

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #389: add healthcheck router

Posted by "zouyx (GitHub)" <gi...@apache.org>.
use getter for get ```c.RequestSuccessiveFailureThreshold```

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #389: add healthcheck router

Posted by "zouyx (GitHub)" <gi...@apache.org>.
apache license

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #389: add healthcheck router

Posted by "zouyx (GitHub)" <gi...@apache.org>.
```suggestion
	return circuitBreakerTimeout > protocol.CurrentTimeMillis()
```

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #389: add healthcheck router

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=h1) Report
> Merging [#389](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/989c00194d016fedb7296fc2f0c35c3c8c5d8c7a?src=pr&el=desc) will **increase** coverage by `0.25%`.
> The diff coverage is `86.51%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/389/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #389      +/-   ##
===========================================
+ Coverage     67.1%   67.35%   +0.25%     
===========================================
  Files          157      161       +4     
  Lines         8244     8332      +88     
===========================================
+ Hits          5532     5612      +80     
- Misses        2191     2198       +7     
- Partials       521      522       +1
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `100% <100%> (ø)` | |
| [protocol/rpc\_status.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcnBjX3N0YXR1cy5nbw==) | `72.22% <100%> (+3.96%)` | :arrow_up: |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `66.66% <66.66%> (ø)` | |
| [cluster/router/healthcheck/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZmFjdG9yeS5nbw==) | `66.66% <66.66%> (ø)` | |
| [cluster/router/healthcheck/health\_check\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svaGVhbHRoX2NoZWNrX3JvdXRlLmdv) | `69.23% <69.23%> (ø)` | |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0%> (-1.22%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=footer). Last update [989c001...9674573](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] CodingSinger commented on pull request #389: add healthcheck router

Posted by "CodingSinger (GitHub)" <gi...@apache.org>.
done

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #389: add healthcheck router

Posted by "zouyx (GitHub)" <gi...@apache.org>.
// circuitTrippedTimeoutFactor 

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #389: add healthcheck router

Posted by "zouyx (GitHub)" <gi...@apache.org>.
I think those variable are private , should lower case. 

Use getter/setter for change value.

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] CodingSinger commented on pull request #389: add healthcheck router

Posted by "CodingSinger (GitHub)" <gi...@apache.org>.
done

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on issue #389: add healthcheck router

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
LGTM

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #389: add healthcheck router

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=h1) Report
> Merging [#389](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/989c00194d016fedb7296fc2f0c35c3c8c5d8c7a?src=pr&el=desc) will **increase** coverage by `0.19%`.
> The diff coverage is `86.36%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/389/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           develop    #389      +/-   ##
==========================================
+ Coverage     67.1%   67.3%   +0.19%     
==========================================
  Files          157     161       +4     
  Lines         8244    8331      +87     
==========================================
+ Hits          5532    5607      +75     
- Misses        2191    2201      +10     
- Partials       521     523       +2
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `100% <100%> (ø)` | |
| [protocol/rpc\_status.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcnBjX3N0YXR1cy5nbw==) | `72.22% <100%> (+3.96%)` | :arrow_up: |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `66.66% <66.66%> (ø)` | |
| [cluster/router/healthcheck/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZmFjdG9yeS5nbw==) | `66.66% <66.66%> (ø)` | |
| [cluster/router/healthcheck/health\_check\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svaGVhbHRoX2NoZWNrX3JvdXRlLmdv) | `68% <68%> (ø)` | |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0%> (-1.22%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=footer). Last update [989c001...91830f5](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #389: add healthcheck router

Posted by "zouyx (GitHub)" <gi...@apache.org>.
apache license

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #389: add healthcheck router

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
ealthyInvokers = make([]protocol.Invoker, 0, len(invokers))

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #389: add healthcheck router

Posted by "zouyx (GitHub)" <gi...@apache.org>.
as above

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] CodingSinger commented on pull request #389: add healthcheck router

Posted by "CodingSinger (GitHub)" <gi...@apache.org>.
good suggestion.

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #389: add healthcheck router

Posted by "zouyx (GitHub)" <gi...@apache.org>.
add comment for it

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] CodingSinger commented on pull request #389: add healthcheck router

Posted by "CodingSinger (GitHub)" <gi...@apache.org>.
done.

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #389: add healthcheck router

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=h1) Report
> Merging [#389](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/989c00194d016fedb7296fc2f0c35c3c8c5d8c7a?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `85.54%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/389/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #389      +/-   ##
===========================================
+ Coverage     67.1%   67.11%   +0.01%     
===========================================
  Files          157      161       +4     
  Lines         8244     8326      +82     
===========================================
+ Hits          5532     5588      +56     
- Misses        2191     2213      +22     
- Partials       521      525       +4
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `100% <100%> (ø)` | |
| [protocol/rpc\_status.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcnBjX3N0YXR1cy5nbw==) | `72.22% <100%> (+3.96%)` | :arrow_up: |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `66.66% <66.66%> (ø)` | |
| [cluster/router/healthcheck/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZmFjdG9yeS5nbw==) | `66.66% <66.66%> (ø)` | |
| [cluster/router/healthcheck/health\_check\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svaGVhbHRoX2NoZWNrX3JvdXRlLmdv) | `69.23% <69.23%> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `35.29% <0%> (-29.42%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0%> (-1.71%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0%> (-1.22%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/dubbo-go/pull/389/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=footer). Last update [989c001...9674573](https://codecov.io/gh/apache/dubbo-go/pull/389?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #389: add healthcheck router

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
u can init url and enabled in this way

r := &HealthCheckRouter{
	 url : url,
	 enabled : url.GetParamBool(HEALTH_ROUTE_ENABLED_KEY, false),
     }

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #389: add healthcheck router

Posted by "zouyx (GitHub)" <gi...@apache.org>.
i think those variable are private , should lower case.

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #389: add healthcheck router

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
delete the else branch

[ Full content available at: https://github.com/apache/dubbo-go/pull/389 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org