You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/07/20 12:56:28 UTC
Review Request 60997: Write audit log to solr failure.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60997/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1698
https://issues.apache.org/jira/browse/RANGER-1698
Repository: ranger
Description
-------
Plugin writed audit log to solr failure because of the lack of noggit-0.6.jar in plugin lib path.
The following issue removed the related dependency:
RANGER-1587 - Cleanup Ranger KMS service dependencies.
Diffs
-----
agents-audit/pom.xml c8bd1d8
kms/pom.xml bc0d96f
pom.xml 3fcc4aa
Diff: https://reviews.apache.org/r/60997/diff/1/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 60997: Write audit log to solr failure.
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On July 24, 2017, 4:40 p.m., Colm O hEigeartaigh wrote:
> > Why is the noggit dependency introduced in agents-audit? Also the protobuf version in the root pom that isn't used? You need to make the changes to src/main/assembly/kms.xml as I explained above.
Actually all of the files that reference noggit in src/main/assembly should be changed along these lines:
<include>org.noggit:noggit:jar:${noggit.version}</include>
with
<include>org.noggit:noggit</include>
That includes the noggit jar in the plugins without having to add a dependency in the poms. We should also do the same for:
'com.google.protobuf:protobuf-java:jar:${protobuf-java.version}
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60997/#review181226
-----------------------------------------------------------
On July 24, 2017, 1:23 p.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60997/
> -----------------------------------------------------------
>
> (Updated July 24, 2017, 1:23 p.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1698
> https://issues.apache.org/jira/browse/RANGER-1698
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Plugin writed audit log to solr failure because of the lack of noggit-0.6.jar in plugin lib path.
> The following issue removed the related dependency:
> RANGER-1587 - Cleanup Ranger KMS service dependencies.
>
>
> Diffs
> -----
>
> agents-audit/pom.xml c8bd1d8
> pom.xml 3fcc4aa
>
>
> Diff: https://reviews.apache.org/r/60997/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 60997: Write audit log to solr failure.
Posted by pengjianhua <pe...@zte.com.cn>.
> On 七月 24, 2017, 4:40 p.m., Colm O hEigeartaigh wrote:
> > Why is the noggit dependency introduced in agents-audit? Also the protobuf version in the root pom that isn't used? You need to make the changes to src/main/assembly/kms.xml as I explained above.
>
> Colm O hEigeartaigh wrote:
> Actually all of the files that reference noggit in src/main/assembly should be changed along these lines:
>
>
> <include>org.noggit:noggit:jar:${noggit.version}</include>
>
> with
>
> <include>org.noggit:noggit</include>
>
> That includes the noggit jar in the plugins without having to add a dependency in the poms. We should also do the same for:
>
> 'com.google.protobuf:protobuf-java:jar:${protobuf-java.version}
Ok. I rebuilt the patch after carefully checked and verified it. Thanks.
- pengjianhua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60997/#review181226
-----------------------------------------------------------
On 七月 25, 2017, 9:32 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60997/
> -----------------------------------------------------------
>
> (Updated 七月 25, 2017, 9:32 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1698
> https://issues.apache.org/jira/browse/RANGER-1698
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Plugin writed audit log to solr failure because of the lack of noggit-0.6.jar in plugin lib path.
> The following issue removed the related dependency:
> RANGER-1587 - Cleanup Ranger KMS service dependencies.
>
>
> Diffs
> -----
>
> pom.xml 3fcc4aa
>
>
> Diff: https://reviews.apache.org/r/60997/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 60997: Write audit log to solr failure.
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60997/#review181226
-----------------------------------------------------------
Why is the noggit dependency introduced in agents-audit? Also the protobuf version in the root pom that isn't used? You need to make the changes to src/main/assembly/kms.xml as I explained above.
- Colm O hEigeartaigh
On July 24, 2017, 1:23 p.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60997/
> -----------------------------------------------------------
>
> (Updated July 24, 2017, 1:23 p.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1698
> https://issues.apache.org/jira/browse/RANGER-1698
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Plugin writed audit log to solr failure because of the lack of noggit-0.6.jar in plugin lib path.
> The following issue removed the related dependency:
> RANGER-1587 - Cleanup Ranger KMS service dependencies.
>
>
> Diffs
> -----
>
> agents-audit/pom.xml c8bd1d8
> pom.xml 3fcc4aa
>
>
> Diff: https://reviews.apache.org/r/60997/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 60997: Write audit log to solr failure.
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60997/#review181333
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 25, 2017, 9:32 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60997/
> -----------------------------------------------------------
>
> (Updated July 25, 2017, 9:32 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1698
> https://issues.apache.org/jira/browse/RANGER-1698
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Plugin writed audit log to solr failure because of the lack of noggit-0.6.jar in plugin lib path.
> The following issue removed the related dependency:
> RANGER-1587 - Cleanup Ranger KMS service dependencies.
>
>
> Diffs
> -----
>
> pom.xml 3fcc4aa
>
>
> Diff: https://reviews.apache.org/r/60997/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 60997: Write audit log to solr failure.
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60997/
-----------------------------------------------------------
(Updated 七月 25, 2017, 9:32 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1698
https://issues.apache.org/jira/browse/RANGER-1698
Repository: ranger
Description
-------
Plugin writed audit log to solr failure because of the lack of noggit-0.6.jar in plugin lib path.
The following issue removed the related dependency:
RANGER-1587 - Cleanup Ranger KMS service dependencies.
Diffs (updated)
-----
pom.xml 3fcc4aa
Diff: https://reviews.apache.org/r/60997/diff/3/
Changes: https://reviews.apache.org/r/60997/diff/2-3/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 60997: Write audit log to solr failure.
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60997/
-----------------------------------------------------------
(Updated 七月 24, 2017, 1:23 p.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1698
https://issues.apache.org/jira/browse/RANGER-1698
Repository: ranger
Description
-------
Plugin writed audit log to solr failure because of the lack of noggit-0.6.jar in plugin lib path.
The following issue removed the related dependency:
RANGER-1587 - Cleanup Ranger KMS service dependencies.
Diffs (updated)
-----
agents-audit/pom.xml c8bd1d8
pom.xml 3fcc4aa
Diff: https://reviews.apache.org/r/60997/diff/2/
Changes: https://reviews.apache.org/r/60997/diff/1-2/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 60997: Write audit log to solr failure.
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60997/#review181115
-----------------------------------------------------------
Actually there is a better way to fix this. Instead of adding the noggit dependency back in, instead modify src/main/assembly/kms.xml + replace:
<include>org.noggit:noggit:jar:${noggit.version}</include>
with
<include>org.noggit:noggit</include>
The ews/lib is also missing this jar which it should have:
<include>com.google.protobuf:protobuf-java</include>
- Colm O hEigeartaigh
On July 20, 2017, 12:56 p.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60997/
> -----------------------------------------------------------
>
> (Updated July 20, 2017, 12:56 p.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1698
> https://issues.apache.org/jira/browse/RANGER-1698
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Plugin writed audit log to solr failure because of the lack of noggit-0.6.jar in plugin lib path.
> The following issue removed the related dependency:
> RANGER-1587 - Cleanup Ranger KMS service dependencies.
>
>
> Diffs
> -----
>
> agents-audit/pom.xml c8bd1d8
> kms/pom.xml bc0d96f
> pom.xml 3fcc4aa
>
>
> Diff: https://reviews.apache.org/r/60997/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 60997: Write audit log to solr failure.
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60997/#review181086
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On 七月 20, 2017, 12:56 p.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60997/
> -----------------------------------------------------------
>
> (Updated 七月 20, 2017, 12:56 p.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1698
> https://issues.apache.org/jira/browse/RANGER-1698
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Plugin writed audit log to solr failure because of the lack of noggit-0.6.jar in plugin lib path.
> The following issue removed the related dependency:
> RANGER-1587 - Cleanup Ranger KMS service dependencies.
>
>
> Diffs
> -----
>
> agents-audit/pom.xml c8bd1d8
> kms/pom.xml bc0d96f
> pom.xml 3fcc4aa
>
>
> Diff: https://reviews.apache.org/r/60997/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>