You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2019/01/02 08:00:01 UTC

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )

Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Looks good. Is it tested yet?

http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:

http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/build.gradle@23
PS1, Line 23:   compile libs.osdetector
This looks good. I wonder if Grant can help us ensure it's shaded.



-- 
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 02 Jan 2019 08:00:01 +0000
Gerrit-HasComments: Yes