You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/01/11 21:37:55 UTC

[GitHub] [camel-quarkus] ppalaga opened a new pull request #2123: Debezium MongoDB Connector native support

ppalaga opened a new pull request #2123:
URL: https://github.com/apache/camel-quarkus/pull/2123


   fix #1190
   
   Rebased https://github.com/apache/camel-quarkus/pull/2072 and some minor changes to be able to run the tests on Quarkus Platform.
   
   @JiriOndrusek could you please review?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #2123: Debezium MongoDB Connector native support

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #2123:
URL: https://github.com/apache/camel-quarkus/pull/2123#discussion_r555561912



##########
File path: extensions/debezium-mongodb/runtime/pom.xml
##########
@@ -31,7 +31,7 @@
 
     <properties>
         <camel.quarkus.jvmSince>1.0.0</camel.quarkus.jvmSince>
-        <camel.quarkus.nativeSince>1.0.0</camel.quarkus.nativeSince>
+        <camel.quarkus.nativeSince>1.5.0</camel.quarkus.nativeSince>

Review comment:
       From the time of the original PR, version should be bumped to 1.6.

##########
File path: pom.xml
##########
@@ -56,7 +56,7 @@
         <commons-lang.version>2.6</commons-lang.version><!-- used by hbase, should be pretty stable as commons-lang is not developed actively anymore -->
         <commons-math3.version>3.6.1</commons-math3.version><!-- Mess in the transitive dependencies of Spark and hbase-testing-util -->
         <curator.version>4.3.0</curator.version><!-- Mess in the transitive dependencies of Spark, Zookeeper and other hadoop related components -->
-        <debezium.version>1.3.0.Final</debezium.version>
+        <debezium.version>1.4.0.Beta1</debezium.version>

Review comment:
       Here has to be 1.4.0.Final




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #2123: Debezium MongoDB Connector native support

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2123:
URL: https://github.com/apache/camel-quarkus/pull/2123#issuecomment-758538477


   27a8d50: addressed the comments of @JiriOndrusek 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2123: Debezium MongoDB Connector native support

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2123:
URL: https://github.com/apache/camel-quarkus/pull/2123#discussion_r555636837



##########
File path: extensions/debezium-mongodb/runtime/pom.xml
##########
@@ -31,7 +31,7 @@
 
     <properties>
         <camel.quarkus.jvmSince>1.0.0</camel.quarkus.jvmSince>
-        <camel.quarkus.nativeSince>1.0.0</camel.quarkus.nativeSince>
+        <camel.quarkus.nativeSince>1.5.0</camel.quarkus.nativeSince>

Review comment:
       Good catch, thanks!

##########
File path: pom.xml
##########
@@ -56,7 +56,7 @@
         <commons-lang.version>2.6</commons-lang.version><!-- used by hbase, should be pretty stable as commons-lang is not developed actively anymore -->
         <commons-math3.version>3.6.1</commons-math3.version><!-- Mess in the transitive dependencies of Spark and hbase-testing-util -->
         <curator.version>4.3.0</curator.version><!-- Mess in the transitive dependencies of Spark, Zookeeper and other hadoop related components -->
-        <debezium.version>1.3.0.Final</debezium.version>
+        <debezium.version>1.4.0.Beta1</debezium.version>

Review comment:
       +1, thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga merged pull request #2123: Debezium MongoDB Connector native support

Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #2123:
URL: https://github.com/apache/camel-quarkus/pull/2123


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #2123: Debezium MongoDB Connector native support

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2123:
URL: https://github.com/apache/camel-quarkus/pull/2123#issuecomment-758638919


   The failure in Hazelcast test does not seem to be related.
   
   Thanks, @JiriOndrusek!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org