You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2022/10/26 17:03:33 UTC
[camel] branch main updated (ba422717c59 -> a9e493bbc34)
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
from ba422717c59 (chores) camel-facebook: avoid unnecessary object instantiation
new 09bbb778b17 (chores) camel-aws2-sts: avoid shadowing member variables
new a9e493bbc34 (chores) camel-base-engine: avoid unnecessary object instantiation
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../java/org/apache/camel/component/aws2/sts/STS2Component.java | 8 ++++----
.../java/org/apache/camel/impl/engine/CamelInternalProcessor.java | 3 +--
2 files changed, 5 insertions(+), 6 deletions(-)
[camel] 02/02: (chores) camel-base-engine: avoid unnecessary object instantiation
Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit a9e493bbc3455b289e6f69a2d7aee28ef786a29c
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Wed Oct 26 16:46:44 2022 +0200
(chores) camel-base-engine: avoid unnecessary object instantiation
---
.../main/java/org/apache/camel/impl/engine/CamelInternalProcessor.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/CamelInternalProcessor.java b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/CamelInternalProcessor.java
index 8ae23a74a68..20068a4d892 100644
--- a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/CamelInternalProcessor.java
+++ b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/CamelInternalProcessor.java
@@ -129,8 +129,7 @@ public class CamelInternalProcessor extends DelegateAsyncProcessor implements In
camelContext = null;
reactiveExecutor = null;
shutdownStrategy = null;
- AsyncAfterTask task = new AsyncAfterTask(null);
- log.trace("Loaded {}", task.getClass().getSimpleName());
+ log.trace("Loaded {}", AsyncAfterTask.class.getSimpleName());
}
@Override
[camel] 01/02: (chores) camel-aws2-sts: avoid shadowing member variables
Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 09bbb778b1761fbdfa66c1cb21150e0e7e3a2c7f
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Wed Oct 26 16:43:36 2022 +0200
(chores) camel-aws2-sts: avoid shadowing member variables
---
.../java/org/apache/camel/component/aws2/sts/STS2Component.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/components/camel-aws/camel-aws2-sts/src/main/java/org/apache/camel/component/aws2/sts/STS2Component.java b/components/camel-aws/camel-aws2-sts/src/main/java/org/apache/camel/component/aws2/sts/STS2Component.java
index 3e7acf88743..3c3c6a04de4 100644
--- a/components/camel-aws/camel-aws2-sts/src/main/java/org/apache/camel/component/aws2/sts/STS2Component.java
+++ b/components/camel-aws/camel-aws2-sts/src/main/java/org/apache/camel/component/aws2/sts/STS2Component.java
@@ -49,11 +49,11 @@ public class STS2Component extends DefaultComponent {
@Override
protected Endpoint createEndpoint(String uri, String remaining, Map<String, Object> parameters) throws Exception {
- STS2Configuration configuration = this.configuration != null ? this.configuration.copy() : new STS2Configuration();
- STS2Endpoint endpoint = new STS2Endpoint(uri, this, configuration);
+ STS2Configuration configurationClone = this.configuration != null ? this.configuration.copy() : new STS2Configuration();
+ STS2Endpoint endpoint = new STS2Endpoint(uri, this, configurationClone);
setProperties(endpoint, parameters);
- if (!configuration.isUseDefaultCredentialsProvider() && configuration.getStsClient() == null
- && (configuration.getAccessKey() == null || configuration.getSecretKey() == null)) {
+ if (!configurationClone.isUseDefaultCredentialsProvider() && configurationClone.getStsClient() == null
+ && (configurationClone.getAccessKey() == null || configurationClone.getSecretKey() == null)) {
throw new IllegalArgumentException(
"useDefaultCredentialsProvider is set to false, Amazon STS client or accessKey and secretKey must be specified");
}