[GitHub] [hbase-connectors] jojochuang commented on a change in pull request #86: HBASE-26354 [hbase-connectors] Added python client for HBase thrift service

[GitBox <gi...@apache.org>]

jojochuang commented on a change in pull request #86:
URL: https://github.com/apache/hbase-connectors/pull/86#discussion_r734324336



##########
File path: thrift-python/hbase-client-thrift2/clientbase.py
##########
@@ -0,0 +1,326 @@
+"""
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+"""
+from thbase.config import ClientConfig
+from thbase.connection import Connection
+from thbase.util.handlers import ExceptionHandler, MessageType
+import abc
+import logging
+
+logger = logging.getLogger(__name__)
+
+
+class ClientBase(object):
+    """
+    Abstract class for both thrift1 and thrift2 client. Implemented with Observer design pattern.

Review comment:
       thrift2 only?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org