You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/04/14 12:39:00 UTC

[jira] [Commented] (TINKERPOP-2924) Refactor PropertyMapStep to be able to overwrite map method

    [ https://issues.apache.org/jira/browse/TINKERPOP-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712363#comment-17712363 ] 

ASF GitHub Bot commented on TINKERPOP-2924:
-------------------------------------------

porunov opened a new pull request, #2022:
URL: https://github.com/apache/tinkerpop/pull/2022

   Make all private fields and methods as protected to be able to overwrite some of it's functionality. This allows to overwrite some functionality for optimization purposes.




> Refactor PropertyMapStep to be able to overwrite map method
> -----------------------------------------------------------
>
>                 Key: TINKERPOP-2924
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2924
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: driver
>    Affects Versions: 3.6.2
>            Reporter: Oleksandr Porunov
>            Priority: Minor
>
> We would like to extend `PropertyMapStep` and overwrite some of it's functionality (in `map` method), so that we could leverage multi-query optimization in JanusGraph for `PropertyMapStep`. 
> Unfortunately, some of it's utility methods and  fields are `private`. Thus, we should duplicate `includeToken` logic and we don't have any access to `traversalRing` because it's private and is created inside the constructor.
> I would suggest making all of those private fields / methods as protected (similarly as it's done in `PropertiesStep`), so that there would be a possibility for overwrite without logic duplication.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)