You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/01/28 19:54:35 UTC

[GitHub] [trafficserver] ywkaras commented on a change in pull request #8590: Port #7925 and #8365 from core strategies to parent_select plugin

ywkaras commented on a change in pull request #8590:
URL: https://github.com/apache/trafficserver/pull/8590#discussion_r794847108



##########
File path: plugins/experimental/parent_select/consistenthash.cc
##########
@@ -297,6 +320,8 @@ PLNextHopConsistentHash::next(TSHttpTxn txnp, void *strategyTxn, const char *exc
 
   PL_NH_Debug(PL_NH_DEBUG_TAG, "nextParent NH plugin calling");
 
+  uint32_t const NO_RING_USE_POST_REMAP = uint32_t(0) - 1;

Review comment:
       Constructor-style casts are not Leif-legal but hopefully he won't see it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org