You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/14 17:29:49 UTC
[GitHub] [tvm] tkonolige opened a new pull request, #13375: [Metaschedule] Add partition primitive
tkonolige opened a new pull request, #13375:
URL: https://github.com/apache/tvm/pull/13375
Add partition scheduling primitive. Partition splits a loop into two sequential loops based on a factor. For example:
```
for i in range(10):
x[i] = 0
```
could be partitioned with a factor of 8 to
```
for i in range(8):
x[i] = 0
for i_ in range(2):
i = i_ + 8
x[i] = 0
```
A couple of changes are necessary to support this change. Feature extraction had to be updated to handle loops with zero or negative extent and the parallel vectorize unroll postproc had to be updated to support nested blocks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13375: [Metaschedule] Add partition primitive
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13375:
URL: https://github.com/apache/tvm/pull/13375#issuecomment-1314124651
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @Hzfengsy, @elvin-n, @junrushao <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13375: [Metaschedule] Add partition primitive
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13375:
URL: https://github.com/apache/tvm/pull/13375#issuecomment-1314124649
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @Hzfengsy, @elvin-n, @junrushao <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on a diff in pull request #13375: [Metaschedule] Add partition primitive
Posted by GitBox <gi...@apache.org>.
tkonolige commented on code in PR #13375:
URL: https://github.com/apache/tvm/pull/13375#discussion_r1021900519
##########
src/tir/schedule/analysis/analysis.cc:
##########
@@ -890,7 +890,7 @@ IterVarType GetLoopIterType(const StmtSRef& loop_sref) {
}
});
}
- return false;
+ return true;
Review Comment:
This change makes `GetLoopIterType` recurse into sub-blocks (`true` means visit sub-nodes). This makes `GetLoopIterType` correct in the presence of nested blocks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on a diff in pull request #13375: [Metaschedule] Add partition primitive
Posted by GitBox <gi...@apache.org>.
jwfromm commented on code in PR #13375:
URL: https://github.com/apache/tvm/pull/13375#discussion_r1021898538
##########
src/tir/schedule/analysis/analysis.cc:
##########
@@ -890,7 +890,7 @@ IterVarType GetLoopIterType(const StmtSRef& loop_sref) {
}
});
}
- return false;
+ return true;
Review Comment:
What does this change do? Seems like it could cause side effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org