[GitHub] [incubator-devlake] mindlesscloud commented on a diff in pull request #2274: Refactor collector of worklogs and remotelinks

[GitBox <gi...@apache.org>]

mindlesscloud commented on code in PR #2274:
URL: https://github.com/apache/incubator-devlake/pull/2274#discussion_r902116056


##########
plugins/jira/tasks/changelog_convertor.go:
##########
@@ -123,14 +118,8 @@ func ConvertChangelogs(taskCtx core.SubTaskContext) error {
 				}
 			}
 			if row.Field == "status" {
-				fromStatus, ok := statusMap[row.FromString]
-				if ok {
-					changelog.FromValue = GetStdStatus(fromStatus.StatusCategory)
-				}
-				toStatus, ok := statusMap[row.ToString]
-				if ok {
-					changelog.ToValue = GetStdStatus(toStatus.StatusCategory)
-				}
+				changelog.FromValue = getStdStatus(row.FromString)
+				changelog.ToValue = getStdStatus(row.ToString)

Review Comment:
    `GetStdStatus` and `getStdStatus` are different functions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org