[GitHub] [iceberg] daksha121 commented on a change in pull request #2752: Spark MicroBatch read - implement skipReplace and skipDelete

[GitBox <gi...@apache.org>]

daksha121 commented on a change in pull request #2752:
URL: https://github.com/apache/iceberg/pull/2752#discussion_r661053589



##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkReadOptions.java
##########
@@ -50,4 +50,10 @@ private SparkReadOptions() {
 
   // Set ID that is used to fetch file scan tasks
   public static final String FILE_SCAN_TASK_SET_ID = "file-scan-task-set-id";
+
+  // skip snapshots of type delete while reading stream out of iceberg table
+  public static final String READ_STREAM_SKIP_DELETE = "read-stream-skip-delete";
+
+  // skip snapshots of type replace while reading stream out of iceberg table
+  public static final String READ_STREAM_SKIP_REPLACE = "read-stream-skip-replace";

Review comment:
       That makes sense. Added an explicit option based off of my interpretation of https://github.com/apache/iceberg/pull/2660#discussion_r658351562
   But maybe an explicit option was not the intention of the comment? :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org