You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/09/03 19:02:03 UTC
[GitHub] [netbeans] errael opened a new pull request #2341: [NETBEANS-4696] html parser dont wait for projects open
errael opened a new pull request #2341:
URL: https://github.com/apache/netbeans/pull/2341
The html parser, in twisty paths, is used from many areas (for example, braceMatching). Without this change, the parser waits for project open, and this created a deadlock. (#2340 takes care of one side). However, according to analysis by @jtulach in the issue report, the html parser should not be calling into the projectui api.
This PR does not fix that, it does avoid blocking on the project ui api. A careful analysis of the html parsing code, and how it's used, should be done to see if there are any unexpected consequences of this change.
The eventual goal is to completely remove the dependency as outlined in the analysis as seen in issue [NETBEANS-4696].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] errael commented on pull request #2341: [NETBEANS-4696] html parser dont wait for projects open
Posted by GitBox <gi...@apache.org>.
errael commented on pull request #2341:
URL: https://github.com/apache/netbeans/pull/2341#issuecomment-686803139
Turns out removing the dependency on projectuiapi.base does not change behavior; see issue for details.
@jtulach will you comment and/or review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach merged pull request #2341: [NETBEANS-4696] html parser dont wait for projects open
Posted by GitBox <gi...@apache.org>.
JaroslavTulach merged pull request #2341:
URL: https://github.com/apache/netbeans/pull/2341
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists