[GitHub] [incubator-doris] xy720 commented on a diff in pull request #9311: [feature]add vectorized vjson_scanner

[GitBox <gi...@apache.org>]

xy720 commented on code in PR #9311:
URL: https://github.com/apache/incubator-doris/pull/9311#discussion_r862481511


##########
be/src/exec/base_scanner.h:
##########
@@ -65,6 +72,10 @@ class BaseScanner {
     virtual Status get_next(std::vector<vectorized::MutableColumnPtr>& columns, bool* eof) {
         return Status::NotSupported("Not Implemented get block");
     }
+    
+    virtual Status get_next(vectorized::Block& output_block, bool* eof) {

Review Comment:
   I only see it be implemented in vJsonScanner. May be you also need to implement it in vBrokerScanner, too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org