[GitHub] [druid] abhishekagarwal87 commented on pull request #11302: Add integer parsing in HiLoQueryLaningStrategy

[GitBox <gi...@apache.org>]

abhishekagarwal87 commented on pull request #11302:
URL: https://github.com/apache/druid/pull/11302#issuecomment-855786369


   > ust minor nit comment, not important that you address, only if there are other changes requested by others.
   > 
   > We might want to add an intelliJ inspection to ensure that we catch any future calls to `theQuery.getContextValue` and fail the build if they are found, to avoid this issue in the future.
   
   @zachjsh if you have done this before, can you let me know how to do this? I am assuming we want to flag calls that where `theQuery.getContextValue` returns a non-string value. Or are you suggesting not to invoke this function at all even for string  result? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org