You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "johannaojeling (via GitHub)" <gi...@apache.org> on 2023/04/10 13:57:43 UTC

[GitHub] [beam] johannaojeling commented on a diff in pull request #26192: [Go SDK]: Implement LastModified method in filesystems

johannaojeling commented on code in PR #26192:
URL: https://github.com/apache/beam/pull/26192#discussion_r1161742455


##########
sdks/go/pkg/beam/io/filesystem/filesystem.go:
##########
@@ -92,6 +93,12 @@ type Interface interface {
 // The following interfaces are optional for the filesystems, but
 // to support
 
+// LastModifiedGetter is an interface for getting the last modified time
+// of a file.
+type LastModifiedGetter interface {

Review Comment:
   Let me know if you have a preference for whether this method should be part of `filesystem.Interface` or a standalone interface. (And if the latter, if the name `LastModifiedGetter` is idiomatic enough or if you can think of any better?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org