You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Sadanand Shenoy (Jira)" <ji...@apache.org> on 2023/03/14 12:41:00 UTC

[jira] [Commented] (HDFS-16911) Distcp with snapshot diff to support Ozone filesystem.

    [ https://issues.apache.org/jira/browse/HDFS-16911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700141#comment-17700141 ] 

Sadanand Shenoy commented on HDFS-16911:
----------------------------------------

[~ayushtkn]  , The HADOOP-17719 change is almost similar and a rather simpler approach and I feel we can go with that change only. I have changed my PR to use the same approach , almost a copy of [#3157|https://github.com/apache/hadoop/pull/3157/files%C2%A0] (only difference is a test addition and a getter method for toSnapshot field as this was needed when we implemented getsnapshotDiffReport in Ozone FS).

I think the older PR has been open for a long time and has conflicts, [~iwasakims]  could you also please take a look at this [PR|https://github.com/apache/hadoop/pull/5364] and let me know if there are any objections. 

> Distcp with snapshot diff to support Ozone filesystem.
> ------------------------------------------------------
>
>                 Key: HDFS-16911
>                 URL: https://issues.apache.org/jira/browse/HDFS-16911
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: distcp
>            Reporter: Sadanand Shenoy
>            Priority: Major
>              Labels: pull-request-available
>
> Currently in DistcpSync i.e the step which applies the diff b/w 2 provided snapshots as arguments to the distcp job with -diff option, only DistributedFilesystem and WebHDFS filesytems are supported.
>  
> {code:java}
> // currently we require both the source and the target file system are
> // DistributedFileSystem or (S)WebHdfsFileSystem.
> if (!(srcFs instanceof DistributedFileSystem
>         || srcFs instanceof WebHdfsFileSystem)) {
>   throw new IllegalArgumentException("Unsupported source file system: "
>       + srcFs.getScheme() + "://. " +
>       "Supported file systems: hdfs://, webhdfs:// and swebhdfs://.");
> }
> if (!(tgtFs instanceof DistributedFileSystem
>     || tgtFs instanceof WebHdfsFileSystem)) {
>   throw new IllegalArgumentException("Unsupported target file system: "
>       + tgtFs.getScheme() + "://. " +
>       "Supported file systems: hdfs://, webhdfs:// and swebhdfs://.");
> }{code}
> As Ozone now supports snapshot feature after HDDS-6517, add support to use distcp with ozone snapshots.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org