[GitHub] [trafficserver] traeak commented on a diff in pull request #8591: add proxy.config.http.cache.max_open_write_retry_timeout parameter

[GitBox <gi...@apache.org>]

traeak commented on code in PR #8591:
URL: https://github.com/apache/trafficserver/pull/8591#discussion_r842078291


##########
proxy/http/HttpCacheSM.cc:
##########
@@ -139,18 +139,20 @@ HttpCacheSM::state_cache_open_read(int event, void *data)
     }
     break;
 
-  case EVENT_INTERVAL:
+  case EVENT_INTERVAL: {
     // Retry the cache open read if the number retries is less
     // than or equal to the max number of open read retries,
     // else treat as a cache miss.
-    ink_assert(open_read_tries <= master_sm->t_state.txn_conf->max_cache_open_read_retries || write_locked);
+    bool const retries_done = (master_sm->t_state.txn_conf->max_cache_open_read_retries < open_read_tries);
+    ink_assert(retries_done || write_locked);

Review Comment:
   I had also added in logic to change the read retries over to a timeout as well.  This little snippet here looks like code I didn't back out.



##########
proxy/http/HttpCacheSM.cc:
##########
@@ -139,18 +139,20 @@ HttpCacheSM::state_cache_open_read(int event, void *data)
     }
     break;
 
-  case EVENT_INTERVAL:
+  case EVENT_INTERVAL: {
     // Retry the cache open read if the number retries is less
     // than or equal to the max number of open read retries,
     // else treat as a cache miss.
-    ink_assert(open_read_tries <= master_sm->t_state.txn_conf->max_cache_open_read_retries || write_locked);
+    bool const retries_done = (master_sm->t_state.txn_conf->max_cache_open_read_retries < open_read_tries);
+    ink_assert(retries_done || write_locked);

Review Comment:
   I had also added in logic to change the read retries over to a timeout as well.  This little snippet here looks like code I didn't back out.  Reverting...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org