You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/14 15:45:04 UTC
[GitHub] [superset] cemremengu opened a new pull request, #19721: refactor(frontend): Make dashboard search box the first filter
cemremengu opened a new pull request, #19721:
URL: https://github.com/apache/superset/pull/19721
### SUMMARY
Searching is the most natural filter so most people are looking for it first before checking others. This PR moves `Search` to the beginning of the dashboard filters in an attempt to provide easier accessibility.
Feel free to close this PR if this is not suitable for core team.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
** BEFORE **
**AFTER**
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19721: refactor(frontend): Make dashboard search box the first filter
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #19721:
URL: https://github.com/apache/superset/pull/19721#issuecomment-1337724847
@kasiazjc @jess-dillard any objections to this? If not, we can probably get it through quickly. @cemremengu (or anyone, really) would just need to resolve the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jess-dillard commented on pull request #19721: refactor(frontend): Make dashboard search box the first filter
Posted by GitBox <gi...@apache.org>.
jess-dillard commented on PR #19721:
URL: https://github.com/apache/superset/pull/19721#issuecomment-1337814235
@rusackas No objections here, let's do it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cemremengu commented on a diff in pull request #19721: refactor(frontend): Make dashboard search box the first filter
Posted by GitBox <gi...@apache.org>.
cemremengu commented on code in PR #19721:
URL: https://github.com/apache/superset/pull/19721#discussion_r1041822661
##########
superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx:
##########
@@ -533,13 +539,7 @@ function DashboardList(props: DashboardListProps) {
{ label: t('No'), value: false },
],
},
- {
- Header: t('Search'),
key: 'search',
Review Comment:
Ah apologies, forgot to check CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cemremengu commented on pull request #19721: refactor(frontend): Make dashboard search box the first filter
Posted by GitBox <gi...@apache.org>.
cemremengu commented on PR #19721:
URL: https://github.com/apache/superset/pull/19721#issuecomment-1339059681
@rusackas done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19721: refactor(frontend): Make dashboard search box the first filter
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #19721:
URL: https://github.com/apache/superset/pull/19721#discussion_r1041343947
##########
superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx:
##########
@@ -533,13 +539,7 @@ function DashboardList(props: DashboardListProps) {
{ label: t('No'), value: false },
],
},
- {
- Header: t('Search'),
key: 'search',
Review Comment:
Oops! I think this line needed to come along for the ride!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19721: refactor(frontend): Make dashboard search box the first filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19721:
URL: https://github.com/apache/superset/pull/19721#issuecomment-1099392743
# [Codecov](https://codecov.io/gh/apache/superset/pull/19721?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19721](https://codecov.io/gh/apache/superset/pull/19721?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16576eb) into [master](https://codecov.io/gh/apache/superset/commit/9425dd2cac42f1a92f621848c469cadcc483e757?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9425dd2) will **increase** coverage by `0.00%`.
> The diff coverage is `70.00%`.
> :exclamation: Current head 16576eb differs from pull request most recent head ed4c3bd. Consider uploading reports for the commit ed4c3bd to get more accurate results
```diff
@@ Coverage Diff @@
## master #19721 +/- ##
=======================================
Coverage 66.50% 66.50%
=======================================
Files 1684 1686 +2
Lines 64567 64577 +10
Branches 6631 6633 +2
=======================================
+ Hits 42939 42946 +7
- Misses 19930 19933 +3
Partials 1698 1698
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.15% <70.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19721?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/packages/superset-ui-core/src/models/Registry.ts](https://codecov.io/gh/apache/superset/pull/19721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvbW9kZWxzL1JlZ2lzdHJ5LnRz) | `100.00% <ø> (ø)` | |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/superset/pull/19721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `58.09% <ø> (ø)` | |
| [...rc/dashboard/components/DashboardEmbedControls.tsx](https://codecov.io/gh/apache/superset/pull/19721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEVtYmVkQ29udHJvbHMudHN4) | `9.43% <25.00%> (+1.27%)` | :arrow_up: |
| [...kages/superset-ui-core/src/models/TypedRegistry.ts](https://codecov.io/gh/apache/superset/pull/19721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvbW9kZWxzL1R5cGVkUmVnaXN0cnkudHM=) | `100.00% <100.00%> (ø)` | |
| [...set-ui-core/src/ui-overrides/UiOverrideRegistry.ts](https://codecov.io/gh/apache/superset/pull/19721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdWktb3ZlcnJpZGVzL1VpT3ZlcnJpZGVSZWdpc3RyeS50cw==) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19721?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19721?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9425dd2...ed4c3bd](https://codecov.io/gh/apache/superset/pull/19721?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sfirke commented on pull request #19721: refactor(frontend): Make dashboard search box the first filter
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #19721:
URL: https://github.com/apache/superset/pull/19721#issuecomment-1468698057
Could this be done for Charts view also? And I suppose Dataset view as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19721: refactor(frontend): Make dashboard search box the first filter
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #19721:
URL: https://github.com/apache/superset/pull/19721#issuecomment-1337822001
@cemremengu let me know if you can fix the merge conflict, and we'll get this thing through!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #19721: refactor(frontend): Make dashboard search box the first filter
Posted by GitBox <gi...@apache.org>.
rusackas merged PR #19721:
URL: https://github.com/apache/superset/pull/19721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org