You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2024/03/13 07:51:05 UTC

[PR] [fix](Nereids): slot set in condition can be empty (#32169) [doris]

jackwener opened a new pull request, #32176:
URL: https://github.com/apache/doris/pull/32176

   ## Proposed changes
   
   (cherry picked from commit ca092139a007dca99006d8247d9926947b1490d3)
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids): slot set in condition can be empty (#32169) [doris]

Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang merged PR #32176:
URL: https://github.com/apache/doris/pull/32176


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids): slot set in condition can be empty (#32169) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32176:
URL: https://github.com/apache/doris/pull/32176#issuecomment-1993795614

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 49995 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 334201ebe1964464d02f66ead0bef51a0777b571, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17617	4392	4334	4334
   q2	2046	151	137	137
   q3	10345	1902	1920	1902
   q4	10102	1285	1332	1285
   q5	8504	3930	3942	3930
   q6	220	122	123	122
   q7	2041	1595	1586	1586
   q8	9298	2723	2721	2721
   q9	10592	10526	10403	10403
   q10	8624	3507	3555	3507
   q11	424	247	231	231
   q12	454	298	307	298
   q13	18347	3961	4015	3961
   q14	346	336	324	324
   q15	510	457	456	456
   q16	704	586	592	586
   q17	1128	973	932	932
   q18	7236	6889	7006	6889
   q19	1677	1586	1553	1553
   q20	546	306	298	298
   q21	4504	4135	4136	4135
   q22	505	405	409	405
   Total cold run time: 115770 ms
   Total hot run time: 49995 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4353	4286	4284	4284
   q2	315	220	225	220
   q3	4189	4163	4127	4127
   q4	2768	2764	2793	2764
   q5	7310	7195	7221	7195
   q6	236	123	115	115
   q7	3252	2880	2903	2880
   q8	4392	4542	4580	4542
   q9	17222	17004	17012	17004
   q10	4249	4306	4251	4251
   q11	772	703	673	673
   q12	1024	866	851	851
   q13	7188	3701	3739	3701
   q14	449	423	423	423
   q15	494	451	454	451
   q16	766	703	722	703
   q17	3882	3855	3951	3855
   q18	8828	8793	8880	8793
   q19	1709	1708	1673	1673
   q20	2384	2112	2113	2112
   q21	8569	8667	8480	8480
   q22	1021	956	925	925
   Total cold run time: 85372 ms
   Total hot run time: 80022 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids): slot set in condition can be empty (#32169) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32176:
URL: https://github.com/apache/doris/pull/32176#issuecomment-1993817372

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 202335 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 334201ebe1964464d02f66ead0bef51a0777b571, data reload: false
   
   query1	936	396	381	381
   query2	6526	2373	2293	2293
   query3	6915	198	199	198
   query4	19912	18060	17874	17874
   query5	19717	6505	6460	6460
   query6	280	208	232	208
   query7	4156	292	295	292
   query8	243	230	224	224
   query9	3108	2695	2599	2599
   query10	424	283	293	283
   query11	11222	10622	10686	10622
   query12	115	77	70	70
   query13	5570	629	613	613
   query14	17508	13817	13894	13817
   query15	367	227	243	227
   query16	6446	268	263	263
   query17	1721	1458	861	861
   query18	2323	413	399	399
   query19	200	150	141	141
   query20	76	73	74	73
   query21	188	93	91	91
   query22	5292	5028	5093	5028
   query23	32637	31960	32102	31960
   query24	6923	6520	6478	6478
   query25	519	406	411	406
   query26	522	158	152	152
   query27	1926	287	285	285
   query28	6159	2225	2186	2186
   query29	2822	2780	2782	2780
   query30	257	157	161	157
   query31	898	742	735	735
   query32	70	60	57	57
   query33	383	259	250	250
   query34	856	469	481	469
   query35	1112	909	929	909
   query36	1577	1607	1485	1485
   query37	89	63	60	60
   query38	3088	2956	2891	2891
   query39	1368	1322	1317	1317
   query40	199	87	91	87
   query41	40	37	31	31
   query42	89	86	80	80
   query43	623	748	626	626
   query44	1096	713	709	709
   query45	234	231	225	225
   query46	1240	962	978	962
   query47	1812	1824	1678	1678
   query48	963	684	666	666
   query49	606	370	364	364
   query50	873	598	583	583
   query51	4734	4690	4735	4690
   query52	82	74	71	71
   query53	451	311	306	306
   query54	2614	2440	2471	2440
   query55	83	75	74	74
   query56	211	207	197	197
   query57	1212	1088	1116	1088
   query58	210	201	204	201
   query59	3580	3226	3392	3226
   query60	202	195	195	195
   query61	83	80	79	79
   query62	836	449	536	449
   query63	473	333	337	333
   query64	2527	1486	1453	1453
   query65	3590	3545	3567	3545
   query66	790	367	360	360
   query67	16486	15435	15878	15435
   query68	8462	657	649	649
   query69	551	342	336	336
   query70	1988	1652	1754	1652
   query71	392	310	316	310
   query72	6414	3443	3392	3392
   query73	716	330	319	319
   query74	6259	5868	5818	5818
   query75	5076	3726	3614	3614
   query76	5090	1152	1198	1152
   query77	846	261	249	249
   query78	12554	11620	11570	11570
   query79	8973	627	635	627
   query80	1396	383	390	383
   query81	492	224	227	224
   query82	1685	96	92	92
   query83	171	129	129	129
   query84	264	69	69	69
   query85	996	275	277	275
   query86	382	374	366	366
   query87	3217	3015	2992	2992
   query88	5191	2315	2302	2302
   query89	392	293	265	265
   query90	1868	206	211	206
   query91	148	115	113	113
   query92	53	51	50	50
   query93	5702	553	560	553
   query94	727	196	196	196
   query95	1114	1040	1037	1037
   query96	626	319	313	313
   query97	6491	6315	6323	6315
   query98	191	166	172	166
   query99	2881	854	929	854
   Total cold run time: 311698 ms
   Total hot run time: 202335 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids): slot set in condition can be empty (#32169) [doris]

Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang commented on PR #32176:
URL: https://github.com/apache/doris/pull/32176#issuecomment-1994631201

   https://github.com/apache/doris/pull/32169


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids): slot set in condition can be empty (#32169) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32176:
URL: https://github.com/apache/doris/pull/32176#issuecomment-1993831042

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 334201ebe1964464d02f66ead0bef51a0777b571 with default session variables
   Stream load json:         21 seconds loaded 2358488459 Bytes, about 107 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       20.8 seconds inserted 10000000 Rows, about 480K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids): slot set in condition can be empty (#32169) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32176:
URL: https://github.com/apache/doris/pull/32176#issuecomment-1993825686

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.9 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 334201ebe1964464d02f66ead0bef51a0777b571, data reload: false
   
   query1	0.03	0.02	0.02
   query2	0.06	0.02	0.02
   query3	0.24	0.06	0.05
   query4	1.83	0.07	0.06
   query5	0.53	0.53	0.52
   query6	1.24	0.63	0.62
   query7	0.01	0.01	0.01
   query8	0.03	0.03	0.03
   query9	0.52	0.48	0.47
   query10	0.54	0.53	0.53
   query11	0.11	0.08	0.09
   query12	0.12	0.09	0.09
   query13	0.61	0.61	0.62
   query14	0.77	0.77	0.79
   query15	0.78	0.77	0.75
   query16	0.37	0.37	0.38
   query17	1.02	1.02	1.03
   query18	0.22	0.27	0.27
   query19	1.87	1.87	1.88
   query20	0.01	0.01	0.01
   query21	15.50	0.55	0.55
   query22	2.08	2.89	1.51
   query23	17.11	1.08	0.89
   query24	5.38	1.59	1.15
   query25	0.39	0.16	0.03
   query26	0.68	0.16	0.16
   query27	0.04	0.04	0.03
   query28	7.13	0.74	0.75
   query29	12.66	2.38	2.29
   query30	0.60	0.54	0.55
   query31	2.82	0.38	0.39
   query32	3.39	0.50	0.49
   query33	3.10	3.08	3.09
   query34	15.28	4.78	4.81
   query35	4.86	4.86	4.88
   query36	1.04	1.00	1.01
   query37	0.05	0.04	0.05
   query38	0.04	0.02	0.02
   query39	0.01	0.02	0.01
   query40	0.16	0.14	0.14
   query41	0.07	0.01	0.01
   query42	0.02	0.01	0.01
   query43	0.02	0.02	0.02
   Total cold run time: 103.34 s
   Total hot run time: 30.9 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids): slot set in condition can be empty (#32169) [doris]

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #32176:
URL: https://github.com/apache/doris/pull/32176#issuecomment-1993762625

   
   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids): slot set in condition can be empty (#32169) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32176:
URL: https://github.com/apache/doris/pull/32176#issuecomment-1993752886

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](Nereids): slot set in condition can be empty (#32169) [doris]

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #32176:
URL: https://github.com/apache/doris/pull/32176#issuecomment-1993755362

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org