You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "mukund-thakur (via GitHub)" <gi...@apache.org> on 2023/05/31 18:29:48 UTC

[GitHub] [parquet-mr] mukund-thakur opened a new pull request, #1103: PARQUET-2171. Implement vectored IO in parquet file format

mukund-thakur opened a new pull request, #1103:
URL: https://github.com/apache/parquet-mr/pull/1103

   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [parquet-mr] steveloughran commented on pull request #1103: PARQUET-2171. Implement vectored IO in parquet file format

Posted by "steveloughran (via GitHub)" <gi...@apache.org>.
steveloughran commented on PR #1103:
URL: https://github.com/apache/parquet-mr/pull/1103#issuecomment-1581240289

   Hadoop API shim; now separate ASF repo there.
   https://github.com/apache/hadoop-api-shim


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [parquet-mr] mukund-thakur commented on pull request #1103: PARQUET-2171. Implement vectored IO in parquet file format

Posted by "mukund-thakur (via GitHub)" <gi...@apache.org>.
mukund-thakur commented on PR #1103:
URL: https://github.com/apache/parquet-mr/pull/1103#issuecomment-1579527132

   > If I did an initial alpha asf release of https://github.com/steveloughran/fs-api-shim, what would it take to move this implementation to it?
   
   I think we can include the shim as maven dependency and make the changes here parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ParquetVectoredIOUtil.java . once you release I can try that asap as a POC.  
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [parquet-mr] steveloughran commented on pull request #1103: PARQUET-2171. Implement vectored IO in parquet file format

Posted by "steveloughran (via GitHub)" <gi...@apache.org>.
steveloughran commented on PR #1103:
URL: https://github.com/apache/parquet-mr/pull/1103#issuecomment-1570831629

   If I did an initial alpha asf release of https://github.com/steveloughran/fs-api-shim, what would it take to move this implementation to it? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] PARQUET-2171. Implement vectored IO in parquet file format [parquet-mr]

Posted by "mukund-thakur (via GitHub)" <gi...@apache.org>.
mukund-thakur commented on PR #1103:
URL: https://github.com/apache/parquet-mr/pull/1103#issuecomment-1939658923

   Closing this one as this is being tracked here https://github.com/apache/parquet-mr/pull/1139 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] PARQUET-2171. Implement vectored IO in parquet file format [parquet-mr]

Posted by "mukund-thakur (via GitHub)" <gi...@apache.org>.
mukund-thakur closed pull request #1103: PARQUET-2171. Implement vectored IO in parquet file format
URL: https://github.com/apache/parquet-mr/pull/1103


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org