[GitHub] [doris] yixiutt commented on a diff in pull request #13522: [improvement](publish) add publish version cost

[GitBox <gi...@apache.org>]

yixiutt commented on code in PR #13522:
URL: https://github.com/apache/doris/pull/13522#discussion_r1001588589


##########
be/src/olap/storage_engine.cpp:
##########
@@ -1026,38 +1026,8 @@ void StorageEngine::notify_listeners() {
 }
 
 Status StorageEngine::execute_task(EngineTask* task) {
-    auto lock_related_tablets = [&]() -> std::vector<std::unique_lock<std::shared_mutex>> {
-        // add write lock to all related tablets

Review Comment:
   No engine task has implement get_related_tablets() so it will always return empty, so no locks will acquire here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org