You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by GitBox <gi...@apache.org> on 2019/09/04 09:54:15 UTC
[GitHub] [metron] tigerquoll opened a new pull request #1501: Metron-2246
rpm-docker - minimise use of bind mounts due to performance
tigerquoll opened a new pull request #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance
URL: https://github.com/apache/metron/pull/1501
## Contributor Comments
Docker bind shared folders have a reputation as being fairly slow and inefficient on Docker for Mac. This project restructures the rpm-docker project to stop docker bind folders from being used by the RPM process for input and scratch pad use. Docker bind folders are still used for output of the constructed RPMs.
This PR restructures the rpm-docker project to use a three-stage docker build process. The first docker file is a template with the RPM building tools installed, that will be cached by docker once it is build.
The second phase of the docker build process involves constructing a new docker image based on the 1st phase docker image plus the Metron jars.
The third phase involves running the second phase docker image which will process the Metron Jars and place the packaged rpms into the appropriate folders in the project directory.
## Performance improvement.
On my 2019 MBP, the following performance improvement were obtained:
Unmodified rpm-docker project:
```
mvn package -DskipTests -T 2C -P HDP-2.5.0.0,mpack
cd metron-deployment/
time mvn clean package -Pbuild-rpms -T 2C
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] metron-deployment 0.7.2 ............................ SUCCESS [ 0.763 s]
[INFO] metron-rpm 0.7.2 ................................... SUCCESS [12:21 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12:22 min (Wall Clock)
[INFO] Finished at: 2019-09-04T18:35:12+10:00
[INFO] ------------------------------------------------------------------------
real 12m23.361s
user 0m11.263s
sys 0m8.577s
```
This PR:
```
mvn package -DskipTests -T 2C -P HDP-2.5.0.0,mpack
cd metron-deployment/
time mvn clean package -Pbuild-rpms -T 2C
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] metron-deployment 0.7.2 ............................ SUCCESS [ 0.848 s]
[INFO] metron-rpm 0.7.2 ................................... SUCCESS [09:28 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 09:29 min (Wall Clock)
[INFO] Finished at: 2019-09-04T19:16:38+10:00
[INFO] ------------------------------------------------------------------------
real 9m30.377s
user 0m10.831s
sys 0m7.999s
```
Test plan:
1. run `mvn package -DskipTests -T 2C -P HDP-2.5.0.0,mpack`
2. `cd metron-deployment`
3. `mvn clean package -Pbuild-rpms -T 2C`
4. Check `metron-deployment/packaging/docker/rpm-docker/target/RPMS` for presence of RPMS.
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
- [ ] Have you ensured that any documentation diagrams have been updated, along with their source files, using [draw.io](https://www.draw.io/)? See [Metron Development Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines) for instructions.
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services