You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/09/12 07:27:13 UTC
Review Request 62237: Fixed a memory leak in composing containerizer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62237/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Jie Yu.
Bugs: MESOS-7927
https://issues.apache.org/jira/browse/MESOS-7927
Repository: mesos
Description
-------
Fixed a memory leak in composing containerizer.
Diffs
-----
src/slave/containerizer/composing.cpp c076c74bb09e5d528420cece38e583a1e1ae07c9
Diff: https://reviews.apache.org/r/62237/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 62237: Fixed a memory leak in composing
containerizer.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62237/#review185260
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Sept. 12, 2017, 7:27 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62237/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2017, 7:27 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Jie Yu.
>
>
> Bugs: MESOS-7927
> https://issues.apache.org/jira/browse/MESOS-7927
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a memory leak in composing containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/composing.cpp c076c74bb09e5d528420cece38e583a1e1ae07c9
>
>
> Diff: https://reviews.apache.org/r/62237/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62237: Fixed a memory leak in composing
containerizer.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62237/#review185155
-----------------------------------------------------------
FAIL: Mesos stdout-tests failed to build.
Reviews applied: [62237]
All the build artifacts available here: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62237
Relevant logs:
- stout-tests-cmake-build.log:
C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 \ u s e r \ w i n 3 2 \ g r o u p i n f o . c ( 5 3 ) : w a r n i n g C 4 1 3 3 : ' f u n c t i o n ' : i n c o m p a t i b l e t y p e s - f r o m ' c h a r [ 2 5 6 ] ' t o ' L P W S T R ' [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 - b u i l d \ l i b a p r - 1 . v c x p r o j ] [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 . v c x p r o j ]
C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 \ u s e r \ w i n 3 2 \ g r o u p i n f o . c ( 5 9 ) : w a r n i n g C 4 1 3 3 : ' f u n c t i o n ' : i n c o m p a t i b l e t y p e s - f r o m ' c h a r * ' t o ' L P C W S T R ' [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 - b u i l d \ l i b a p r - 1 . v c x p r o j ] [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 . v c x p r o j ]
C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 \ u s e r \ w i n 3 2 \ g r o u p i n f o . c ( 5 9 ) : w a r n i n g C 4 1 3 3 : ' f u n c t i o n ' : i n c o m p a t i b l e t y p e s - f r o m ' c o n s t c h a r * ' t o ' L P C W S T R ' [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 - b u i l d \ l i b a p r - 1 . v c x p r o j ] [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 . v c x p r o j ]
C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 \ u s e r \ w i n 3 2 \ g r o u p i n f o . c ( 6 0 ) : w a r n i n g C 4 1 3 3 : ' f u n c t i o n ' : i n c o m p a t i b l e t y p e s - f r o m ' c h a r [ 2 5 6 ] ' t o ' L P W S T R ' [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 - b u i l d \ l i b a p r - 1 . v c x p r o j ] [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 . v c x p r o j ]
C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 \ u s e r \ w i n 3 2 \ g r o u p i n f o . c ( 7 9 ) : w a r n i n g C 4 1 3 3 : ' f u n c t i o n ' : i n c o m p a t i b l e t y p e s - f r o m ' c h a r [ 2 6 0 ] ' t o ' L P W S T R ' [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 - b u i l d \ l i b a p r - 1 . v c x p r o j ] [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 . v c x p r o j ]
C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 \ u s e r \ w i n 3 2 \ u s e r i n f o . c ( 1 0 1 ) : w a r n i n g C 4 1 3 3 : ' f u n c t i o n ' : i n c o m p a t i b l e t y p e s - f r o m ' c h a r [ 5 2 0 ] ' t o ' L P C W S T R ' [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 - b u i l d \ l i b a p r - 1 . v c x p r o j ] [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 . v c x p r o j ]
C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 \ u s e r \ w i n 3 2 \ u s e r i n f o . c ( 2 2 7 ) : w a r n i n g C 4 1 3 3 : ' f u n c t i o n ' : i n c o m p a t i b l e t y p e s - f r o m ' c h a r * ' t o ' L P C W S T R ' [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 - b u i l d \ l i b a p r - 1 . v c x p r o j ] [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 . v c x p r o j ]
C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 \ u s e r \ w i n 3 2 \ u s e r i n f o . c ( 2 2 7 ) : w a r n i n g C 4 1 3 3 : ' f u n c t i o n ' : i n c o m p a t i b l e t y p e s - f r o m ' c o n s t c h a r * ' t o ' L P C W S T R ' [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 - b u i l d \ l i b a p r - 1 . v c x p r o j ] [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 . v c x p r o j ]
C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 \ u s e r \ w i n 3 2 \ u s e r i n f o . c ( 2 2 8 ) : w a r n i n g C 4 1 3 3 : ' f u n c t i o n ' : i n c o m p a t i b l e t y p e s - f r o m ' c h a r [ 2 5 6 ] ' t o ' L P W S T R ' [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 - b u i l d \ l i b a p r - 1 . v c x p r o j ] [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 . v c x p r o j ]
C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 \ u s e r \ w i n 3 2 \ u s e r i n f o . c ( 2 3 4 ) : w a r n i n g C 4 1 3 3 : ' f u n c t i o n ' : i n c o m p a t i b l e t y p e s - f r o m ' c h a r * ' t o ' L P C W S T R ' [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 - b u i l d \ l i b a p r - 1 . v c x p r o j ] [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 . v c x p r o j ]
C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 \ u s e r \ w i n 3 2 \ u s e r i n f o . c ( 2 3 4 ) : w a r n i n g C 4 1 3 3 : ' f u n c t i o n ' : i n c o m p a t i b l e t y p e s - f r o m ' c o n s t c h a r * ' t o ' L P C W S T R ' [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 - b u i l d \ l i b a p r - 1 . v c x p r o j ] [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 . v c x p r o j ]
C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 \ u s e r \ w i n 3 2 \ u s e r i n f o . c ( 2 3 5 ) : w a r n i n g C 4 1 3 3 : ' f u n c t i o n ' : i n c o m p a t i b l e t y p e s - f r o m ' c h a r [ 2 5 6 ] ' t o ' L P W S T R ' [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 - b u i l d \ l i b a p r - 1 . v c x p r o j ] [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 . v c x p r o j ]
C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 \ u s e r \ w i n 3 2 \ u s e r i n f o . c ( 2 5 9 ) : w a r n i n g C 4 1 3 3 : ' f u n c t i o n ' : i n c o m p a t i b l e t y p e s - f r o m ' c h a r [ 2 6 0 ] ' t o ' L P W S T R ' [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 \ s r c \ l i b a p r - 1 . 5 . 2 - b u i l d \ l i b a p r - 1 . v c x p r o j ] [ C : \ m e s o s \ 3 r d p a r t y \ l i b a p r - 1 . 5 . 2 . v c x p r o j ]
" C : \ m e s o s \ 3 r d p a r t y \ s t o u t \ t e s t s \ s t o u t - t e s t s . v c x p r o j " ( d e f a u l t t a r g e t ) ( 1 ) - >
" C : \ m e s o s \ 3 r d p a r t y \ p r o t o b u f - 3 . 3 . 0 . v c x p r o j " ( d e f a u l t t a r g e t ) ( 1 0 ) - >
( C u s t o m B u i l d t a r g e t ) - >
C : \ P r o g r a m F i l e s ( x 8 6 ) \ M i c r o s o f t V i s u a l S t u d i o \ 2 0 1 7 \ C o m m u n i t y \ C o m m o n 7 \ I D E \ V C \ V C T a r g e t s \ M i c r o s o f t . C p p C o m m o n . t a r g e t s ( 1 7 1 , 5 ) : e r r o r M S B 6 0 0 6 : " c m d . e x e " e x i t e d w i t h c o d e - 1 . [ C : \ m e s o s \ 3 r d p a r t y \ p r o t o b u f - 3 . 3 . 0 . v c x p r o j ]
" C : \ m e s o s \ 3 r d p a r t y \ s t o u t \ t e s t s \ s t o u t - t e s t s . v c x p r o j " ( d e f a u l t t a r g e t ) ( 1 ) - >
" C : \ m e s o s \ 3 r d p a r t y \ z l i b - 1 . 2 . 8 . v c x p r o j " ( d e f a u l t t a r g e t ) ( 1 1 ) - >
C : \ P r o g r a m F i l e s ( x 8 6 ) \ M i c r o s o f t V i s u a l S t u d i o \ 2 0 1 7 \ C o m m u n i t y \ C o m m o n 7 \ I D E \ V C \ V C T a r g e t s \ M i c r o s o f t . C p p C o m m o n . t a r g e t s ( 1 7 1 , 5 ) : e r r o r M S B 6 0 0 6 : " c m d . e x e " e x i t e d w i t h c o d e - 1 . [ C : \ m e s o s \ 3 r d p a r t y \ z l i b - 1 . 2 . 8 . v c x p r o j ]
1 5 1 W a r n i n g ( s )
2 E r r o r ( s )
T i m e E l a p s e d 0 0 : 1 0 : 2 6 . 2 2
Full log available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62237/logs/stout-tests-cmake-build.log
- Mesos Reviewbot Windows
On Sept. 12, 2017, 7:27 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62237/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2017, 7:27 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Jie Yu.
>
>
> Bugs: MESOS-7927
> https://issues.apache.org/jira/browse/MESOS-7927
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a memory leak in composing containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/composing.cpp c076c74bb09e5d528420cece38e583a1e1ae07c9
>
>
> Diff: https://reviews.apache.org/r/62237/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>