You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/04/11 10:14:16 UTC
Re: Review Request 64211: Added options to build the Python CLI and
run unit tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64211/#review200900
-----------------------------------------------------------
PASS: Mesos patch 64211 was successfully built and tested.
Reviews applied: `['65585', '65705', '64211']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64211
- Mesos Reviewbot Windows
On March 24, 2018, 11:39 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64211/
> -----------------------------------------------------------
>
> (Updated March 24, 2018, 11:39 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Kevin Klues.
>
>
> Bugs: MESOS-8240
> https://issues.apache.org/jira/browse/MESOS-8240
>
>
> Repository: mesos
>
>
> Description
> -------
>
> An update of the discarded review /r/52543.
>
> Works with Autotools and CMake.
>
>
> Diffs
> -----
>
> CMakeLists.txt 6702f02245e3867c06bbd9efbbf4e3b961a7d9aa
> cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c
> configure.ac f0f901f2e565352c2804cae7b2ac255da81ce45d
> docs/configuration/cmake.md 1e34657ea55fa324f65f865f7d0a67084c6719d9
> src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9
> src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a
> src/python/cli_new/CMakeLists.txt PRE-CREATION
> src/python/cli_new/tests/CMakeLists.txt PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64211/diff/17/
>
>
> Testing
> -------
>
> Testing done on Fedora 25.
>
> For Autotools:
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ ../configure --enable-new-cli --disable-java --disable-python
> $ make check
> ```
>
> For CMake:
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
>
> Usage:
> mesos (-h | --help)
> mesos --version
> mesos <command> [<args>...]
>
> Options:
> -h --help Show this screen.
> --version Show version info.
>
> Commands:
> agent Interacts with the Mesos agents
> config Interacts with the Mesos CLI configuration file
> task Interacts with the tasks running in a Mesos cluster
>
> See 'mesos help <command>' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests ......................... Passed 3.63 sec
>
> 100% tests passed, 0 tests failed out of 1
> ```
>
> Checked that the the CLI tests were run, that the content of the directory `build/src/cli` was as expected, and that `build/src/mesos` was correctly running.
>
>
> Thanks,
>
> Armand Grillet
>
>