You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "afs (via GitHub)" <gi...@apache.org> on 2023/06/13 16:47:03 UTC
[GitHub] [jena] afs opened a new pull request, #1906: GH-1905: SERVICE on/off control
afs opened a new pull request, #1906:
URL: https://github.com/apache/jena/pull/1906
GitHub issue resolved #1905
* Centralize control in `Service`
* Add `ServiceExec` as a single point for service-enhancer
* `ARQ.globalServiceAllowed` -- override setting
* `ARQ.allowServiceDefault` -- default is not context setting is found.
Make the test suite run whatever the default settings of the switch of `ARQ.globalServiceAllowed` and `ARQ.allowServiceDefault` are.
----
- [x] Tests are included.
- [x] Commits have been squashed to remove intermediate development commit messages.
- [x] Key commit messages start with the issue number (GH-xxxx, or if in JIRA, JENA-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1906: GH-1905: SERVICE on/off control
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs merged PR #1906:
URL: https://github.com/apache/jena/pull/1906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] rvesse commented on a diff in pull request #1906: GH-1905: SERVICE on/off control
Posted by "rvesse (via GitHub)" <gi...@apache.org>.
rvesse commented on code in PR #1906:
URL: https://github.com/apache/jena/pull/1906#discussion_r1228443827
##########
jena-arq/src/main/java/org/apache/jena/query/ARQ.java:
##########
@@ -277,11 +293,25 @@ public static void enableBlankNodeResultLabels(boolean val) {
public static final Symbol httpServiceAllowed = SystemARQ.allocSymbol("httpServiceAllowed");
//public static final Symbol httpQueryCompression = SystemARQ.allocSymbol("httpQueryCompression");
+
+ /** {@link HttpClient} to use. */
public static final Symbol httpQueryClient = SystemARQ.allocSymbol("httpQueryClient");
+ /**
+ * Context to use to set up the SERVICE call.
+ * @deprecated This no longer does anything. Cpontext come sformthe query
Review Comment:
```suggestion
* @deprecated This no longer does anything. Context come from the query
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org