You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/04/15 19:01:39 UTC

[Impala-ASF-CR] WIP: Bump CDP BUILD NUMBER to 1020239

Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13002


Change subject: WIP: Bump CDP_BUILD_NUMBER to 1020239
......................................................................

WIP: Bump CDP_BUILD_NUMBER to 1020239

This patch bumps the CDP_BUILD_NUMBER to 1020239. This patch also
refactors the bootstrap_toolchain.py to be more generic for dealing with
CDP components, e.g. Ranger and Hive 3.

Testing:
- Ran core tests

Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M buildall.sh
M fe/pom.xml
M impala-parent/pom.xml
5 files changed, 76 insertions(+), 78 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/13002/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.

Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
......................................................................

IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201

This patch bumps the CDP_BUILD_NUMBER to 1013201. This patch also
refactors the bootstrap_toolchain.py to be more generic for dealing with
CDP components, e.g. Ranger and Hive 3.

The patch also fixes some TODOs to replace the rangerPlugin.init() hack
with rangerPlugin.refreshPoliciesAndTags() API available in this Ranger
build.

Testing:
- Ran core tests
- Manually verified that no regression when starting Hive 3 with
  USE_CDP_HIVE=true

Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
---
M .gitignore
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/mvn-quiet.sh
M buildall.sh
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M impala-parent/pom.xml
M testdata/cluster/ranger/ranger-admin-default-site.xml.template
D testdata/cluster/ranger/security-applicationContext.xml
10 files changed, 84 insertions(+), 227 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/13002/11
-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
......................................................................


Patch Set 12: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 12
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 05:30:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
......................................................................


Patch Set 11:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2808/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Apr 2019 23:30:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.

Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
......................................................................


Patch Set 11: Code-Review+1

> Patch Set 10:
> 
> Hi Fredy, was wondering if you were able to start minicluster which spins up HMS3 using this build? Just wanted to make sure that we are not regressing IMPALA-8345 until we have automated jobs running against hive-3

I tested starting the minicluster with Hive 3 and no problem so far. I updated the commit message.

Carry Joe's +1.


-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Apr 2019 22:49:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.

Fredy Wijaya has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
......................................................................

IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201

This patch bumps the CDP_BUILD_NUMBER to 1013201. This patch also
refactors the bootstrap_toolchain.py to be more generic for dealing with
CDP components, e.g. Ranger and Hive 3.

The patch also fixes some TODOs to replace the rangerPlugin.init() hack
with rangerPlugin.refreshPoliciesAndTags() API available in this Ranger
build.

Testing:
- Ran core tests

Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
---
M .gitignore
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/mvn-quiet.sh
M buildall.sh
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M impala-parent/pom.xml
M testdata/cluster/ranger/ranger-admin-default-site.xml.template
D testdata/cluster/ranger/security-applicationContext.xml
10 files changed, 84 insertions(+), 227 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/13002/10
-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 10
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1013201

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.

Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/13002 )

Change subject: Bump CDP_BUILD_NUMBER to 1013201
......................................................................

Bump CDP_BUILD_NUMBER to 1013201

This patch bumps the CDP_BUILD_NUMBER to 1013201. This patch also
refactors the bootstrap_toolchain.py to be more generic for dealing with
CDP components, e.g. Ranger and Hive 3.

Testing:
- Ran core tests

Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
---
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/mvn-quiet.sh
M buildall.sh
M impala-parent/pom.xml
M testdata/cluster/ranger/ranger-admin-default-site.xml.template
D testdata/cluster/ranger/security-applicationContext.xml
8 files changed, 80 insertions(+), 221 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/13002/7
-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
......................................................................

IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201

This patch bumps the CDP_BUILD_NUMBER to 1013201. This patch also
refactors the bootstrap_toolchain.py to be more generic for dealing with
CDP components, e.g. Ranger and Hive 3.

The patch also fixes some TODOs to replace the rangerPlugin.init() hack
with rangerPlugin.refreshPoliciesAndTags() API available in this Ranger
build.

Testing:
- Ran core tests
- Manually verified that no regression when starting Hive 3 with
  USE_CDP_HIVE=true

Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Reviewed-on: http://gerrit.cloudera.org:8080/13002
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M .gitignore
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/mvn-quiet.sh
M buildall.sh
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M impala-parent/pom.xml
M testdata/cluster/ranger/ranger-admin-default-site.xml.template
D testdata/cluster/ranger/security-applicationContext.xml
10 files changed, 84 insertions(+), 227 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 13
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
......................................................................


Patch Set 10: Code-Review+1

(1 comment)

This looks fine to me. I can +2 once other reviewers have a chance to look.

http://gerrit.cloudera.org:8080/#/c/13002/10/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

http://gerrit.cloudera.org:8080/#/c/13002/10/bin/bootstrap_toolchain.py@420
PS10, Line 420: download_cdp_components
This is getting very similar to download_cdh_components. At some point, we should consider combining them.



-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 10
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Apr 2019 20:46:36 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.

Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
......................................................................


Patch Set 11: Code-Review+1

Thanks for making the changes and testing that HMS3 comes up.


-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Apr 2019 22:50:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1013201

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.

Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/13002 )

Change subject: Bump CDP_BUILD_NUMBER to 1013201
......................................................................

Bump CDP_BUILD_NUMBER to 1013201

This patch bumps the CDP_BUILD_NUMBER to 1013201. This patch also
refactors the bootstrap_toolchain.py to be more generic for dealing with
CDP components, e.g. Ranger and Hive 3.

Testing:
- Ran core tests

Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
---
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/mvn-quiet.sh
M buildall.sh
M impala-parent/pom.xml
M testdata/cluster/ranger/ranger-admin-default-site.xml.template
D testdata/cluster/ranger/security-applicationContext.xml
8 files changed, 80 insertions(+), 221 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/13002/6
-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1013201

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.

Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 )

Change subject: Bump CDP_BUILD_NUMBER to 1013201
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/13002/3/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

http://gerrit.cloudera.org:8080/#/c/13002/3/bin/bootstrap_toolchain.py@508
PS3, Line 508:   toolchain_host = os.environ["IMPALA_TOOLCHAIN_HOST"]
             :   cdh_build_number = os.environ["CDH_BUILD_NUMBER"]
> nit: looks like it's safe to just use os.environ['IMPALA_TOOLCHAIN_HOST'] a
Done


http://gerrit.cloudera.org:8080/#/c/13002/3/bin/bootstrap_toolchain.py@538
PS3, Line 538:   if use_cdp_hive:
             :     cdp_components
> Since use_cdp_hive is not used again:
Ah yeah, this is duplicated in L512. Done.


http://gerrit.cloudera.org:8080/#/c/13002/3/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/13002/3/buildall.sh@540
PS3, Line 540:  
> extraneous #.. There's two more in this parragraph
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Apr 2019 17:11:07 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
......................................................................


Patch Set 12:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4029/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 12
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 00:15:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1013201

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.

Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/13002 )

Change subject: Bump CDP_BUILD_NUMBER to 1013201
......................................................................

Bump CDP_BUILD_NUMBER to 1013201

This patch bumps the CDP_BUILD_NUMBER to 1013201. This patch also
refactors the bootstrap_toolchain.py to be more generic for dealing with
CDP components, e.g. Ranger and Hive 3.

Testing:
- Ran core tests

Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
---
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M buildall.sh
M impala-parent/pom.xml
M testdata/cluster/ranger/ranger-admin-default-site.xml.template
D testdata/cluster/ranger/security-applicationContext.xml
7 files changed, 76 insertions(+), 218 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/13002/5
-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1013201

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.

Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 )

Change subject: Bump CDP_BUILD_NUMBER to 1013201
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13002/5/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

http://gerrit.cloudera.org:8080/#/c/13002/5/bin/bootstrap_toolchain.py@426
PS5, Line 426: set.")
> nit, Since CDP_COMPONENTS_HOME is a env variable, it is perhaps more correc
Done


http://gerrit.cloudera.org:8080/#/c/13002/5/impala-parent/pom.xml
File impala-parent/pom.xml:

http://gerrit.cloudera.org:8080/#/c/13002/5/impala-parent/pom.xml@114
PS5, Line 114: <id>impala.cdp.repo</id>
> I noticed, that adding such a repository generates a lot of warnings during
Good idea. Done.



-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Apr 2019 18:15:21 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 )

Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201
......................................................................


Patch Set 11: Code-Review+2

Bump this to +2


-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 00:14:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1013201

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.

Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 )

Change subject: Bump CDP_BUILD_NUMBER to 1013201
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13002/5/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

http://gerrit.cloudera.org:8080/#/c/13002/5/bin/bootstrap_toolchain.py@426
PS5, Line 426: present
nit, Since CDP_COMPONENTS_HOME is a env variable, it is perhaps more correct to say make sure it is set than is present.


http://gerrit.cloudera.org:8080/#/c/13002/5/impala-parent/pom.xml
File impala-parent/pom.xml:

http://gerrit.cloudera.org:8080/#/c/13002/5/impala-parent/pom.xml@114
PS5, Line 114: <id>impala.cdp.repo</id>
I noticed, that adding such a repository generates a lot of warnings during build since maven tries to find the artificates in cdp repo first and then goes to cdh repo. While this is not a issue per say, it would be good to find a way to fix these warnings if possible or update the mvn-quiet.sh to ignore such warnings from being printed.



-- 
To view, visit http://gerrit.cloudera.org:8080/13002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada
Gerrit-Change-Number: 13002
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Apr 2019 17:47:38 +0000
Gerrit-HasComments: Yes