You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Aaron Wood <aa...@verizon.com> on 2016/12/21 22:02:58 UTC

Review Request 54949: Remove the use of FORTIFY_SOURCE from Mesos.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54949/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Bugs: MESOS-6829
    https://issues.apache.org/jira/browse/MESOS-6829


Repository: mesos


Description
-------

FORTIFY_SOURCE is no longer used when hardening. This is to prevent the warning that some versions of gcc/libc throw when FORTIFY_SOURCE is used without optimizations. The warning turns into an error via `-Werror` which is applied to `MESOS_CPPFLAGS` thus failing the whole build.


Diffs
-----

  src/Makefile.am abcf7eed7 

Diff: https://reviews.apache.org/r/54949/diff/


Testing
-------

Build all of Mesos from source.


Thanks,

Aaron Wood

Re: Review Request 54949: Remove the use of FORTIFY_SOURCE from Mesos.

Posted by Michael Park <mp...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54949/#review159882
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Dec. 21, 2016, 2:02 p.m., Aaron Wood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54949/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2016, 2:02 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-6829
>     https://issues.apache.org/jira/browse/MESOS-6829
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> FORTIFY_SOURCE is no longer used when hardening. This is to prevent the warning that some versions of gcc/libc throw when FORTIFY_SOURCE is used without optimizations. The warning turns into an error via `-Werror` which is applied to `MESOS_CPPFLAGS` thus failing the whole build.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am abcf7eed7 
> 
> Diff: https://reviews.apache.org/r/54949/diff/
> 
> 
> Testing
> -------
> 
> Build all of Mesos from source.
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>