You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/02/16 06:44:17 UTC

[kudu-CR] [rpc] fix typo in Messenger::metric entity() 

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9351


Change subject: [rpc] fix typo in Messenger::metric_entity()
......................................................................

[rpc] fix typo in Messenger::metric_entity()

Change-Id: Ic976a5038e982d92318ca5441866fbd05858b92a
---
M src/kudu/rpc/messenger.h
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/9351/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic976a5038e982d92318ca5441866fbd05858b92a
Gerrit-Change-Number: 9351
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [rpc] fix typo in Messenger::metric entity()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9351 )

Change subject: [rpc] fix typo in Messenger::metric_entity()
......................................................................


Patch Set 1: Verified+1

Unrelated flakes due to clock sync errors.


-- 
To view, visit http://gerrit.cloudera.org:8080/9351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic976a5038e982d92318ca5441866fbd05858b92a
Gerrit-Change-Number: 9351
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 16 Feb 2018 07:46:02 +0000
Gerrit-HasComments: No

[kudu-CR] [rpc] fix typo in Messenger::metric entity()

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9351 )

Change subject: [rpc] fix typo in Messenger::metric_entity()
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic976a5038e982d92318ca5441866fbd05858b92a
Gerrit-Change-Number: 9351
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 16 Feb 2018 21:27:50 +0000
Gerrit-HasComments: No

[kudu-CR] [rpc] fix typo in Messenger::metric entity()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [rpc] fix typo in Messenger::metric_entity()
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/9351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic976a5038e982d92318ca5441866fbd05858b92a
Gerrit-Change-Number: 9351
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [rpc] fix typo in Messenger::metric entity()

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9351 )

Change subject: [rpc] fix typo in Messenger::metric_entity()
......................................................................

[rpc] fix typo in Messenger::metric_entity()

Change-Id: Ic976a5038e982d92318ca5441866fbd05858b92a
Reviewed-on: http://gerrit.cloudera.org:8080/9351
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/rpc/messenger.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alexey Serbin: Verified
  Todd Lipcon: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/9351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic976a5038e982d92318ca5441866fbd05858b92a
Gerrit-Change-Number: 9351
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>