You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "haiyang1985 (GitHub)" <gi...@apache.org> on 2019/09/11 06:13:38 UTC
[GitHub] [dubbo] haiyang1985 opened pull request #5051: specify
service annotation protocol
## What is the purpose of the change
XXXXX
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/dubbo/pull/5051 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] CLAassistant commented on issue #5051: specify
service annotation protocol
Posted by "CLAassistant (GitHub)" <gi...@apache.org>.
[](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) before we can accept your contribution.<br/><hr/>**vghy顾海洋** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).<br/><sub>You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=5051) it.</sub>
[ Full content available at: https://github.com/apache/dubbo/pull/5051 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] CLAassistant commented on issue #5051: specify
service annotation protocol
Posted by "CLAassistant (GitHub)" <gi...@apache.org>.
[](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) before we can accept your contribution.<br/><hr/>**vghy顾海洋** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).<br/><sub>You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=5051) it.</sub>
[ Full content available at: https://github.com/apache/dubbo/pull/5051 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] CLAassistant commented on issue #5051: specify
service annotation protocol
Posted by "CLAassistant (GitHub)" <gi...@apache.org>.
[](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) before we can accept your contribution.<br/><hr/>**vghy顾海洋** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).<br/><sub>You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=5051) it.</sub>
[ Full content available at: https://github.com/apache/dubbo/pull/5051 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] chickenlj closed pull request #5051: specify service
annotation protocol
Posted by "chickenlj (GitHub)" <gi...@apache.org>.
[ pull request closed by chickenlj ]
[ Full content available at: https://github.com/apache/dubbo/pull/5051 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] CLAassistant commented on issue #5051: specify
service annotation protocol
Posted by "CLAassistant (GitHub)" <gi...@apache.org>.
[](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) before we can accept your contribution.<br/><hr/>**vghy顾海洋** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).<br/><sub>You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=5051) it.</sub>
[ Full content available at: https://github.com/apache/dubbo/pull/5051 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] sonymoon commented on pull request #5051: specify
service annotation protocol
Posted by "sonymoon (GitHub)" <gi...@apache.org>.
> getBean method will cause the initialization of ProtocolConfig's bean too early
I have created a PR #5063.. to avoid the eager initialization of ProtocolConfig's bean
[ Full content available at: https://github.com/apache/dubbo/pull/5051 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] CLAassistant commented on issue #5051: specify
service annotation protocol
Posted by "CLAassistant (GitHub)" <gi...@apache.org>.
[](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) before we can accept your contribution.<br/><hr/>**vghy顾海洋** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).<br/><sub>You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=5051) it.</sub>
[ Full content available at: https://github.com/apache/dubbo/pull/5051 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] CLAassistant commented on issue #5051: specify
service annotation protocol
Posted by "CLAassistant (GitHub)" <gi...@apache.org>.
[](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) before we can accept your contribution.<br/><hr/>**vghy顾海洋** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).<br/><sub>You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=5051) it.</sub>
[ Full content available at: https://github.com/apache/dubbo/pull/5051 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] haiyang1985 closed pull request #5051: specify
service annotation protocol
Posted by "haiyang1985 (GitHub)" <gi...@apache.org>.
[ pull request closed by haiyang1985 ]
[ Full content available at: https://github.com/apache/dubbo/pull/5051 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org