You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Ryan Baxter (JIRA)" <ji...@apache.org> on 2012/09/13 21:27:08 UTC

[jira] [Created] (SHINDIG-1869) OAuth verifier not being added to requests because of recent OAuth popup changes

Ryan Baxter created SHINDIG-1869:
------------------------------------

             Summary: OAuth verifier not being added to requests because of recent OAuth popup changes
                 Key: SHINDIG-1869
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1869
             Project: Shindig
          Issue Type: Bug
            Reporter: Ryan Baxter
            Assignee: Dan Dumont
             Fix For: 2.5.0, 2.5.0-beta5


I was able to reproduce this with a gadget using OAuth 1.0a.  The OAuthCallbackServlet returns some javascript which calls window.opener...  Before the change to the OAuth popup code window.opener was the gadget window, however now it is the container.  So the variable gadgets.io.oauthReceivedCallbackUrl_ is never actually set in the gadget window, only in the container.  The oauthReceivedCallbackUrl_ contains parameters that may be necessary when making requests for resources protected by oauth and the provider may reject them if they are missing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (SHINDIG-1869) OAuth verifier not being added to requests because of recent OAuth popup changes

Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Dumont reopened SHINDIG-1869:
---------------------------------

    
> OAuth verifier not being added to requests because of recent OAuth popup changes
> --------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1869
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1869
>             Project: Shindig
>          Issue Type: Bug
>            Reporter: Ryan Baxter
>            Assignee: Dan Dumont
>             Fix For: 2.5.0-beta5
>
>
> I was able to reproduce this with a gadget using OAuth 1.0a.  The OAuthCallbackServlet returns some javascript which calls window.opener...  Before the change to the OAuth popup code window.opener was the gadget window, however now it is the container.  So the variable gadgets.io.oauthReceivedCallbackUrl_ is never actually set in the gadget window, only in the container.  The oauthReceivedCallbackUrl_ contains parameters that may be necessary when making requests for resources protected by oauth and the provider may reject them if they are missing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (SHINDIG-1869) OAuth verifier not being added to requests because of recent OAuth popup changes

Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Dumont resolved SHINDIG-1869.
---------------------------------

    Resolution: Invalid

Made obsolete by reverting original fix.
Revert committed in r1388199.
                
> OAuth verifier not being added to requests because of recent OAuth popup changes
> --------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1869
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1869
>             Project: Shindig
>          Issue Type: Bug
>            Reporter: Ryan Baxter
>            Assignee: Dan Dumont
>             Fix For: 2.5.0-beta5
>
>
> I was able to reproduce this with a gadget using OAuth 1.0a.  The OAuthCallbackServlet returns some javascript which calls window.opener...  Before the change to the OAuth popup code window.opener was the gadget window, however now it is the container.  So the variable gadgets.io.oauthReceivedCallbackUrl_ is never actually set in the gadget window, only in the container.  The oauthReceivedCallbackUrl_ contains parameters that may be necessary when making requests for resources protected by oauth and the provider may reject them if they are missing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (SHINDIG-1869) OAuth verifier not being added to requests because of recent OAuth popup changes

Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Dumont closed SHINDIG-1869.
-------------------------------

    
> OAuth verifier not being added to requests because of recent OAuth popup changes
> --------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1869
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1869
>             Project: Shindig
>          Issue Type: Bug
>            Reporter: Ryan Baxter
>            Assignee: Dan Dumont
>             Fix For: 2.5.0-beta5
>
>
> I was able to reproduce this with a gadget using OAuth 1.0a.  The OAuthCallbackServlet returns some javascript which calls window.opener...  Before the change to the OAuth popup code window.opener was the gadget window, however now it is the container.  So the variable gadgets.io.oauthReceivedCallbackUrl_ is never actually set in the gadget window, only in the container.  The oauthReceivedCallbackUrl_ contains parameters that may be necessary when making requests for resources protected by oauth and the provider may reject them if they are missing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (SHINDIG-1869) OAuth verifier not being added to requests because of recent OAuth popup changes

Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Dumont resolved SHINDIG-1869.
---------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.5.0)

Committed r1387331
                
> OAuth verifier not being added to requests because of recent OAuth popup changes
> --------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1869
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1869
>             Project: Shindig
>          Issue Type: Bug
>            Reporter: Ryan Baxter
>            Assignee: Dan Dumont
>             Fix For: 2.5.0-beta5
>
>
> I was able to reproduce this with a gadget using OAuth 1.0a.  The OAuthCallbackServlet returns some javascript which calls window.opener...  Before the change to the OAuth popup code window.opener was the gadget window, however now it is the container.  So the variable gadgets.io.oauthReceivedCallbackUrl_ is never actually set in the gadget window, only in the container.  The oauthReceivedCallbackUrl_ contains parameters that may be necessary when making requests for resources protected by oauth and the provider may reject them if they are missing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira