You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "guyinyou (via GitHub)" <gi...@apache.org> on 2023/08/17 03:55:59 UTC
[GitHub] [rocketmq] guyinyou opened a new pull request, #7202: [ISSUE #7201] Remove the DefaultMessageStore.class dependency in TransientStorePool
guyinyou opened a new pull request, #7202:
URL: https://github.com/apache/rocketmq/pull/7202
….class
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #issue_id
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #7202: [ISSUE #7201] Remove the DefaultMessageStore.class dependency in TransientStorePool
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7202:
URL: https://github.com/apache/rocketmq/pull/7202#issuecomment-1681587926
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7202?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7202](https://app.codecov.io/gh/apache/rocketmq/pull/7202?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (362c9d1) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/5a3de926b816db5a121c1d788430072a3bc942ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5a3de92) will **increase** coverage by `0.00%`.
> Report is 1 commits behind head on develop.
> The diff coverage is `24.19%`.
```diff
@@ Coverage Diff @@
## develop #7202 +/- ##
==========================================
Coverage 42.47% 42.48%
- Complexity 9352 9357 +5
==========================================
Files 1149 1149
Lines 82042 82059 +17
Branches 10699 10699
==========================================
+ Hits 34847 34862 +15
+ Misses 42837 42829 -8
- Partials 4358 4368 +10
```
| [Files Changed](https://app.codecov.io/gh/apache/rocketmq/pull/7202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../rocketmq/broker/metrics/BrokerMetricsManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbWV0cmljcy9Ccm9rZXJNZXRyaWNzTWFuYWdlci5qYXZh) | `11.27% <0.00%> (-0.62%)` | :arrow_down: |
| [...che/rocketmq/broker/metrics/PopMetricsManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbWV0cmljcy9Qb3BNZXRyaWNzTWFuYWdlci5qYXZh) | `28.97% <0.00%> (+0.26%)` | :arrow_up: |
| [...q/controller/metrics/ControllerMetricsManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9tZXRyaWNzL0NvbnRyb2xsZXJNZXRyaWNzTWFuYWdlci5qYXZh) | `19.37% <0.00%> (ø)` | |
| [...ketmq/remoting/metrics/RemotingMetricsManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL21ldHJpY3MvUmVtb3RpbmdNZXRyaWNzTWFuYWdlci5qYXZh) | `11.11% <0.00%> (+0.30%)` | :arrow_up: |
| [...ache/rocketmq/store/AllocateMappedFileService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0FsbG9jYXRlTWFwcGVkRmlsZVNlcnZpY2UuamF2YQ==) | `39.28% <0.00%> (ø)` | |
| [...n/java/org/apache/rocketmq/store/MessageStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/7202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL01lc3NhZ2VTdG9yZS5qYXZh) | `0.00% <ø> (ø)` | |
| [...etmq/store/metrics/DefaultStoreMetricsManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL21ldHJpY3MvRGVmYXVsdFN0b3JlTWV0cmljc01hbmFnZXIuamF2YQ==) | `18.01% <ø> (ø)` | |
| [...ketmq/store/plugin/AbstractPluginMessageStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/7202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3BsdWdpbi9BYnN0cmFjdFBsdWdpbk1lc3NhZ2VTdG9yZS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/rocketmq/common/BrokerConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/7202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vQnJva2VyQ29uZmlnLmphdmE=) | `27.23% <25.00%> (-0.02%)` | :arrow_down: |
| [...org/apache/rocketmq/store/DefaultMessageStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/7202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `46.75% <25.00%> (-0.19%)` | :arrow_down: |
| ... and [3 more](https://app.codecov.io/gh/apache/rocketmq/pull/7202?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [26 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7202/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #7202: [ISSUE #7201] Remove the DefaultMessageStore.class dependency in TransientStorePool
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #7202:
URL: https://github.com/apache/rocketmq/pull/7202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org