[GitHub] [doris] yiguolei commented on a diff in pull request #11131: [Improvement] support tablet schema cache

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #11131:
URL: https://github.com/apache/doris/pull/11131#discussion_r930657541


##########
be/src/exec/olap_scanner.cpp:
##########
@@ -83,7 +83,7 @@ Status OlapScanner::prepare(
             LOG(WARNING) << ss.str();
             return Status::InternalError(ss.str());
         }
-        _tablet_schema = _tablet->tablet_schema();

Review Comment:
   better not copy tablet_schema, because TableSchema does not define copy constructor.  There is a filed  TabletColumn* _parent = nullptr; in tablet column, need change it to shared ptr?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org