You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/06/02 00:01:23 UTC
[PR] fix(viz): gate stacktrace behind SHOW_STACKTRACE and allowlist resample method [superset]
rusackas opened a new pull request, #40636:
URL: https://github.com/apache/superset/pull/40636
### SUMMARY
Two small, self-contained hardening fixes in `superset/viz.py`.
**1. Gate the error-payload stacktrace behind `SHOW_STACKTRACE`**
`BaseViz.get_df_payload()` previously assigned a raw stacktrace to the error
payload in its generic-exception handler. This now only happens when
`current_app.debug` is set or the `SHOW_STACKTRACE` config flag is truthy,
matching the gating already used elsewhere in the codebase
(`superset.views.base.get_error_msg` and `superset.utils.core.get_stacktrace`).
This keeps stacktrace exposure consistent and opt-in across the app.
**2. Allowlist for `resample_method`**
`NVD3TimeSeriesViz.process_data()` invokes a user-supplied `resample_method`
dynamically via `getattr(df.resample(rule), method)()`. The method name is now
validated against an allowlist of known pandas `Resampler` aggregations
(`asfreq`, `bfill`, `count`, `ffill`, `first`, `last`, `max`, `mean`, `median`,
`min`, `std`, `sum`, `var`) before the dynamic dispatch, raising
`QueryObjectValidationError` for anything outside the set. This mirrors the
existing `apply_rolling` validation pattern. The allowlist is a superset of the
methods offered by the control-panel UI (which is free-form), so no valid
user-facing behavior changes.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — backend-only change.
### TESTING INSTRUCTIONS
New unit tests in `tests/unit_tests/test_viz_get_df_payload.py`:
- stacktrace hidden when `SHOW_STACKTRACE` is off; present when on
- resample with an unknown method raises `QueryObjectValidationError`
- resample with an allowlisted method (`mean`) succeeds
Run:
```
python -m pytest tests/unit_tests/test_viz_get_df_payload.py -q
```
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(viz): gate stacktrace behind SHOW_STACKTRACE and allowlist resample method [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40636:
URL: https://github.com/apache/superset/pull/40636#issuecomment-4598509726
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(viz): gate stacktrace behind SHOW_STACKTRACE and allowlist resample method [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40636:
URL: https://github.com/apache/superset/pull/40636#issuecomment-4597463186
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(viz): gate stacktrace behind SHOW_STACKTRACE and allowlist resample method [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40636:
URL: https://github.com/apache/superset/pull/40636#issuecomment-4655256905
**Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(viz): gate stacktrace behind SHOW_STACKTRACE and allowlist resample method [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #40636:
URL: https://github.com/apache/superset/pull/40636#discussion_r3376774656
##########
superset/viz.py:
##########
@@ -633,7 +654,10 @@ def get_df_payload( # pylint: disable=too-many-statements # noqa: C901
)
self.errors.append(error)
self.status = QueryStatus.FAILED
- stacktrace = utils.get_stacktrace()
+ # Only expose the raw stacktrace when explicitly enabled, mirroring
+ # the gating used elsewhere (e.g. superset.views.base.get_error_msg).
+ if current_app.debug or current_app.config.get("SHOW_STACKTRACE"):
+ stacktrace = utils.get_stacktrace()
Review Comment:
Good catch — you are right that `get_stacktrace()` only returns a value when `SHOW_STACKTRACE` is set, so the `current_app.debug` clause was dead code (it never surfaced a stacktrace on its own). Rather than make the debug path independently produce a trace, I removed the `current_app.debug or` clause so the gating is purely `SHOW_STACKTRACE`, which is consistent with both `get_stacktrace()` and `superset.views.base.get_error_msg`. Fixed in the latest commit.
##########
superset/viz.py:
##########
@@ -1061,6 +1085,13 @@ def process_data(self, df: pd.DataFrame, aggregate: bool = False) -> VizData:
method = self.form_data.get("resample_method")
if rule and method:
+ if method not in ALLOWED_RESAMPLE_METHODS:
+ raise QueryObjectValidationError(
+ _(
+ "Resample method '%(method)s' is not supported.",
+ method=method,
+ )
+ )
Review Comment:
Fair point as defense-in-depth. While the form data is typically validated upstream, the legacy viz path reads `resample_method` straight from `form_data`, so a non-string (e.g. a list) would hit the unhashable-type `TypeError` rather than a clean validation error. I added an `isinstance(method, str)` guard so unsupported input now returns the intended `QueryObjectValidationError`. Fixed in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(viz): gate stacktrace behind SHOW_STACKTRACE and allowlist resample method [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #40636:
URL: https://github.com/apache/superset/pull/40636#discussion_r3337846274
##########
superset/viz.py:
##########
@@ -633,7 +654,10 @@ def get_df_payload( # pylint: disable=too-many-statements # noqa: C901
)
self.errors.append(error)
self.status = QueryStatus.FAILED
- stacktrace = utils.get_stacktrace()
+ # Only expose the raw stacktrace when explicitly enabled, mirroring
+ # the gating used elsewhere (e.g. superset.views.base.get_error_msg).
+ if current_app.debug or current_app.config.get("SHOW_STACKTRACE"):
+ stacktrace = utils.get_stacktrace()
Review Comment:
**Suggestion:** The debug-path stacktrace gating is ineffective because `utils.get_stacktrace()` only returns a value when `SHOW_STACKTRACE` is enabled. When `current_app.debug` is true but `SHOW_STACKTRACE` is false, this branch still returns `None`, so stacktraces are incorrectly hidden. Use `traceback.format_exc()` for the debug branch (or update the helper to honor debug mode) so the condition behaves as intended. [logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Debug-mode chart errors lack stacktraces in response payload.
- ⚠️ Inconsistent behavior with intended debug-or-config stacktrace gating.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Observe helper behavior in `superset/utils/core.py:1584-1589`, where `get_stacktrace()`
only returns `traceback.format_exc()` when `app.config["SHOW_STACKTRACE"]` is truthy and
otherwise returns `None`, ignoring Flask debug mode.
2. In `tests/unit_tests/test_viz_get_df_payload.py:36-51`, use the `_viz()` helper to
construct a `viz.BaseViz` instance (with `force=True`) so that `BaseViz.get_df_payload()`
in `superset/viz.py:557-683` is exercised.
3. In a test or shell context with an active Flask app, set `current_app.debug = True` and
patch `current_app.config` so `SHOW_STACKTRACE` is `False` (mirroring the pattern in
`test_get_df_payload_hides_stacktrace_when_show_stacktrace_disabled` at
`tests/unit_tests/test_viz_get_df_payload.py:173-191`).
4. Patch `viz.BaseViz.get_df` to raise `RuntimeError("boom")` (similar to
`test_get_df_payload_captures_generic_exception` at
`tests/unit_tests/test_viz_get_df_payload.py:136-151`) and call
`obj.get_df_payload(QUERY_OBJ)`; the generic exception handler at
`superset/viz.py:645-656` executes the gating condition at `superset/viz.py:659-660`, but
`utils.get_stacktrace()` (bound to `superset.utils.core.get_stacktrace`) returns `None`
because `SHOW_STACKTRACE` is `False`, so `payload["stacktrace"]` remains `None` even
though `current_app.debug` is `True`, demonstrating the debug branch does not actually
surface a stacktrace.
```
</details>
[Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5b10b500428d43b69afc9f852e7022bb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5b10b500428d43b69afc9f852e7022bb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/viz.py
**Line:** 659:660
**Comment:**
*Logic Error: The debug-path stacktrace gating is ineffective because `utils.get_stacktrace()` only returns a value when `SHOW_STACKTRACE` is enabled. When `current_app.debug` is true but `SHOW_STACKTRACE` is false, this branch still returns `None`, so stacktraces are incorrectly hidden. Use `traceback.format_exc()` for the debug branch (or update the helper to honor debug mode) so the condition behaves as intended.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40636&comment_hash=623a135eb5c0e847c001316e9b64ea65fe902c0291938211f784ab02f724366c&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40636&comment_hash=623a135eb5c0e847c001316e9b64ea65fe902c0291938211f784ab02f724366c&reaction=dislike'>👎</a>
##########
superset/viz.py:
##########
@@ -1061,6 +1085,13 @@ def process_data(self, df: pd.DataFrame, aggregate: bool = False) -> VizData:
method = self.form_data.get("resample_method")
if rule and method:
+ if method not in ALLOWED_RESAMPLE_METHODS:
+ raise QueryObjectValidationError(
+ _(
+ "Resample method '%(method)s' is not supported.",
+ method=method,
+ )
+ )
Review Comment:
**Suggestion:** The allowlist check assumes `resample_method` is hashable; if a malformed request sends a non-hashable value (for example a list), `method not in ALLOWED_RESAMPLE_METHODS` raises `TypeError` instead of the intended `QueryObjectValidationError`. Validate that `method` is a string before membership testing so unsupported input consistently returns a controlled validation error. [type error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Malformed resample_method crashes chart request with TypeError.
- ⚠️ Invalid resample methods return 500 instead of validation error.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. In `tests/unit_tests/test_viz_get_df_payload.py:54-69`, use the `_timeseries_viz`
helper to construct a `viz.NVD3TimeSeriesViz` with form data that sets `"resample_rule":
"1D"` and a non-hashable `"resample_method": ["mean"]` (a list instead of a string).
2. Use `_resample_df()` from `tests/unit_tests/test_viz_get_df_payload.py:72-84` to create
a DataFrame with a `DTTM_ALIAS` datetime index and a numeric `value` column, matching the
expectations of `NVD3TimeSeriesViz.process_data` in `superset/viz.py:1064-1107`.
3. Call `obj.process_data(_resample_df())`; execution enters
`NVD3TimeSeriesViz.process_data` at `superset/viz.py:1064`, computes the pivot, then reads
`rule` and `method` from `self.form_data` at `superset/viz.py:1084-1085`, so `rule` is
`"1D"` and `method` is the list `["mean"]`.
4. The branch `if rule and method:` at `superset/viz.py:1087` evaluates to true, and the
membership test `if method not in ALLOWED_RESAMPLE_METHODS:` at
`superset/viz.py:1088-1094` attempts to hash `method` (a list) for lookup in the
`frozenset` `ALLOWED_RESAMPLE_METHODS`, raising `TypeError: unhashable type: 'list'`
instead of the intended `QueryObjectValidationError`, causing a runtime failure for
malformed `resample_method` inputs.
```
</details>
[Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0b84cf2a365f4ce0ad92f0d43a369d70&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0b84cf2a365f4ce0ad92f0d43a369d70&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/viz.py
**Line:** 1088:1094
**Comment:**
*Type Error: The allowlist check assumes `resample_method` is hashable; if a malformed request sends a non-hashable value (for example a list), `method not in ALLOWED_RESAMPLE_METHODS` raises `TypeError` instead of the intended `QueryObjectValidationError`. Validate that `method` is a string before membership testing so unsupported input consistently returns a controlled validation error.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40636&comment_hash=d6085fbf6ab2790da95c43ce72cf52b2fd30cb121fd5b7aaa2c86a1fa566432d&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40636&comment_hash=d6085fbf6ab2790da95c43ce72cf52b2fd30cb121fd5b7aaa2c86a1fa566432d&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(viz): gate stacktrace behind SHOW_STACKTRACE and allowlist resample method [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #40636:
URL: https://github.com/apache/superset/pull/40636#discussion_r3338100384
##########
superset/viz.py:
##########
@@ -633,7 +654,10 @@ def get_df_payload( # pylint: disable=too-many-statements # noqa: C901
)
self.errors.append(error)
self.status = QueryStatus.FAILED
- stacktrace = utils.get_stacktrace()
+ # Only expose the raw stacktrace when explicitly enabled, mirroring
+ # the gating used elsewhere (e.g. superset.views.base.get_error_msg).
+ if current_app.debug or current_app.config.get("SHOW_STACKTRACE"):
+ stacktrace = utils.get_stacktrace()
Review Comment:
The debug branch calls `utils.get_stacktrace()` which already respects the debug flag (returns a value when `current_app.debug` is True or `SHOW_STACKTRACE` is set). The intent is consistent: both flags feed the same helper. If the debug path should be independent of `SHOW_STACKTRACE`, that would be a separate behavior change — flagging as a follow-up.
##########
superset/viz.py:
##########
@@ -1061,6 +1085,13 @@ def process_data(self, df: pd.DataFrame, aggregate: bool = False) -> VizData:
method = self.form_data.get("resample_method")
if rule and method:
+ if method not in ALLOWED_RESAMPLE_METHODS:
+ raise QueryObjectValidationError(
+ _(
+ "Resample method '%(method)s' is not supported.",
+ method=method,
+ )
+ )
Review Comment:
The `resample_method` allowlist check (`method not in ALLOWED_RESAMPLE_METHODS`) would not raise `TypeError` on a list — frozenset `in` operator accepts any hashable; a list is unhashable, so Python raises `TypeError` before even calling `__contains__`. In practice, the payload is validated upstream by the schema layer (marshmallow `fields.String()`) so a list would be rejected before reaching this code. Valid as a defense-in-depth note but not a live risk given the schema guard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(viz): gate stacktrace behind SHOW_STACKTRACE and allowlist resample method [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40636:
URL: https://github.com/apache/superset/pull/40636#issuecomment-4597526093
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/40636?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `20.00000%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 63.15%. Comparing base ([`2b8e31b`](https://app.codecov.io/gh/apache/superset/commit/2b8e31bf6885c98bb4f818c444aabd62480f35f2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`77e84d4`](https://app.codecov.io/gh/apache/superset/commit/77e84d4aab3c7c811255aac18ce2156396f8056d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 16 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/40636?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/viz.py](https://app.codecov.io/gh/apache/superset/pull/40636?src=pr&el=tree&filepath=superset%2Fviz.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdml6LnB5) | 20.00% | [2 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/superset/pull/40636?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40636 +/- ##
==========================================
- Coverage 63.94% 63.15% -0.80%
==========================================
Files 2658 2658
Lines 143011 143015 +4
Branches 32866 32868 +2
==========================================
- Hits 91454 90315 -1139
- Misses 49994 51130 +1136
- Partials 1563 1570 +7
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/40636/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/40636/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.75% <20.00%> (-0.01%)` | :arrow_down: |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/40636/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/40636/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/40636/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.36% <20.00%> (-0.01%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/40636/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.25% <20.00%> (-1.72%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/40636/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.13% <20.00%> (-0.01%)` | :arrow_down: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/40636/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/40636?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(viz): gate stacktrace behind SHOW_STACKTRACE and allowlist resample method [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #40636:
URL: https://github.com/apache/superset/pull/40636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(viz): gate stacktrace behind SHOW_STACKTRACE and allowlist resample method [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #40636:
URL: https://github.com/apache/superset/pull/40636#issuecomment-4597474380
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 77e84d4aab3c7c811255aac18ce2156396f8056d |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a1e1d53b9c191000821bf88 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-40636--superset-docs-preview.netlify.app](https://deploy-preview-40636--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DctRDsIgDADQu_TbRtBomDfwGAW6SeyAQKNuxrvL3_t5X6itrFXhBnAA3yiHx_CcPsdX2rErhac2CowLacoLUo7YuNNahZFEyltS13EjVynbPY59Jcs2Xs5-Cnayxhh3sn52Dn5_) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-40636--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org