You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Brian Anderson (JIRA)" <ji...@apache.org> on 2016/08/03 19:49:20 UTC

[jira] [Created] (CB-11665) Navigation to Fragment locations within Webview are parsed as an error

Brian Anderson created CB-11665:
-----------------------------------

             Summary: Navigation to Fragment locations within Webview are parsed as an error
                 Key: CB-11665
                 URL: https://issues.apache.org/jira/browse/CB-11665
             Project: Apache Cordova
          Issue Type: Bug
          Components: iOS
         Environment: cordova-ios
            Reporter: Brian Anderson


In the CDVUIWebviewDelegate if a fragment is loaded on a url the shouldStartLoadWithRequest gets called and sets the _state to STATE_WAITING_FOR_LOAD_START. Being that when a fragment is loaded the didStartLoading and didFinishLoading callbacks are not called, the next time a link is clicked within our WebView the _state doesn't match any cases, falls into the default case which then handles the request as an error by explicitly calling didFailLoadWithError. I am curious if this is by design as I do notice that STATE_IOS5_POLLING_FOR_LOAD_START is handled in shouldStartLoadWithRequest. Is there a specific case that we would actually want to throw an error?

My suggestion for fixing this would be to add STATE_WAITING_FOR_LOAD_START to the same fall through case as STATE_IDLE, STATE_IOS5_POLLING_FOR_LOAD_START, STATE_CANCELLED. Which would basically just reset the state and loadCount seeing as we have essentially 'cancelled' that pending request from the eyes of cordova. 

Hoping to get more information about these decisions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org