You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by abdelhakim deneche <ad...@gmail.com> on 2015/06/12 18:16:21 UTC
Review Request 35393: DRILL-3220: IOB Exception when using constants
in window functions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35393/
-----------------------------------------------------------
Review request for drill and Aman Sinha.
Bugs: DRILL-3220
https://issues.apache.org/jira/browse/DRILL-3220
Repository: drill-git
Description
-------
Made changes to DrillWindowRule and WindowPrel to properly handle constants in OVER clause
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWindowRule.java 76939d9
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrel.java 4f6551a
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java 4295002
exec/java-exec/src/test/resources/window/q1.sql PRE-CREATION
exec/java-exec/src/test/resources/window/q2.sql PRE-CREATION
exec/java-exec/src/test/resources/window/q3218.sql PRE-CREATION
exec/java-exec/src/test/resources/window/q3220.sql PRE-CREATION
Diff: https://reviews.apache.org/r/35393/diff/
Testing
-------
Thanks,
abdelhakim deneche
Re: Review Request 35393: DRILL-3220: IOB Exception when using
constants in window functions
Posted by abdelhakim deneche <ad...@gmail.com>.
> On June 15, 2015, 7:13 a.m., Aman Sinha wrote:
> > Does the constant argument work for something other than COUNT ? For instance:
> > SELECT SUM(5) OVER (partition by <column>) FROM t;
> > I think this may produce wrong result but that may be a separate issue...
This produces wrong results indeed
- abdelhakim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35393/#review87899
-----------------------------------------------------------
On June 12, 2015, 5:40 p.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35393/
> -----------------------------------------------------------
>
> (Updated June 12, 2015, 5:40 p.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-3220
> https://issues.apache.org/jira/browse/DRILL-3220
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Made changes to DrillWindowRule and WindowPrel to properly handle constants in OVER clause
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWindowRule.java 76939d9
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrel.java 4f6551a
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java 4295002
> exec/java-exec/src/test/resources/window/q1.sql PRE-CREATION
> exec/java-exec/src/test/resources/window/q2.sql PRE-CREATION
> exec/java-exec/src/test/resources/window/q3218.sql PRE-CREATION
> exec/java-exec/src/test/resources/window/q3220.sql PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35393/diff/
>
>
> Testing
> -------
>
> all unit tests are passing along with functional and tpch100
>
>
> Thanks,
>
> abdelhakim deneche
>
>
Re: Review Request 35393: DRILL-3220: IOB Exception when using
constants in window functions
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35393/#review87899
-----------------------------------------------------------
Does the constant argument work for something other than COUNT ? For instance:
SELECT SUM(5) OVER (partition by <column>) FROM t;
I think this may produce wrong result but that may be a separate issue...
- Aman Sinha
On June 12, 2015, 5:40 p.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35393/
> -----------------------------------------------------------
>
> (Updated June 12, 2015, 5:40 p.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-3220
> https://issues.apache.org/jira/browse/DRILL-3220
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Made changes to DrillWindowRule and WindowPrel to properly handle constants in OVER clause
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWindowRule.java 76939d9
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrel.java 4f6551a
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java 4295002
> exec/java-exec/src/test/resources/window/q1.sql PRE-CREATION
> exec/java-exec/src/test/resources/window/q2.sql PRE-CREATION
> exec/java-exec/src/test/resources/window/q3218.sql PRE-CREATION
> exec/java-exec/src/test/resources/window/q3220.sql PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35393/diff/
>
>
> Testing
> -------
>
> all unit tests are passing along with functional and tpch100
>
>
> Thanks,
>
> abdelhakim deneche
>
>
Re: Review Request 35393: DRILL-3220: IOB Exception when using
constants in window functions
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35393/#review87927
-----------------------------------------------------------
Ship it!
This looks ok to commit. Pls open a separate bug for the SUM(constant).
- Aman Sinha
On June 12, 2015, 5:40 p.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35393/
> -----------------------------------------------------------
>
> (Updated June 12, 2015, 5:40 p.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-3220
> https://issues.apache.org/jira/browse/DRILL-3220
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Made changes to DrillWindowRule and WindowPrel to properly handle constants in OVER clause
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWindowRule.java 76939d9
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrel.java 4f6551a
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java 4295002
> exec/java-exec/src/test/resources/window/q1.sql PRE-CREATION
> exec/java-exec/src/test/resources/window/q2.sql PRE-CREATION
> exec/java-exec/src/test/resources/window/q3218.sql PRE-CREATION
> exec/java-exec/src/test/resources/window/q3220.sql PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35393/diff/
>
>
> Testing
> -------
>
> all unit tests are passing along with functional and tpch100
>
>
> Thanks,
>
> abdelhakim deneche
>
>
Re: Review Request 35393: DRILL-3220: IOB Exception when using
constants in window functions
Posted by abdelhakim deneche <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35393/
-----------------------------------------------------------
(Updated June 12, 2015, 5:40 p.m.)
Review request for drill and Aman Sinha.
Bugs: DRILL-3220
https://issues.apache.org/jira/browse/DRILL-3220
Repository: drill-git
Description
-------
Made changes to DrillWindowRule and WindowPrel to properly handle constants in OVER clause
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWindowRule.java 76939d9
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrel.java 4f6551a
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java 4295002
exec/java-exec/src/test/resources/window/q1.sql PRE-CREATION
exec/java-exec/src/test/resources/window/q2.sql PRE-CREATION
exec/java-exec/src/test/resources/window/q3218.sql PRE-CREATION
exec/java-exec/src/test/resources/window/q3220.sql PRE-CREATION
Diff: https://reviews.apache.org/r/35393/diff/
Testing (updated)
-------
all unit tests are passing along with functional and tpch100
Thanks,
abdelhakim deneche