You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/06/02 22:46:04 UTC
[Impala-ASF-CR] [tools] Fix tar argument ordering to exclude .pyc
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18587
Change subject: [tools] Fix tar argument ordering to exclude .pyc
......................................................................
[tools] Fix tar argument ordering to exclude .pyc
Moves `--exclude='*.pyc'` before the files to add as required by tar on
Debian. Fixes the message
> tar: --exclude ‘*.pyc’ has no effect
Change-Id: I79e344f2df6f27e8961ed9d949e59d44cce5d10f
---
M shell/make_shell_tarball.sh
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/18587/1
--
To view, visit http://gerrit.cloudera.org:8080/18587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I79e344f2df6f27e8961ed9d949e59d44cce5d10f
Gerrit-Change-Number: 18587
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] [tools] Fix tar argument ordering to exclude .pyc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18587 )
Change subject: [tools] Fix tar argument ordering to exclude .pyc
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e344f2df6f27e8961ed9d949e59d44cce5d10f
Gerrit-Change-Number: 18587
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 05:00:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Fix tar argument ordering to exclude .pyc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18587 )
Change subject: [tools] Fix tar argument ordering to exclude .pyc
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8183/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e344f2df6f27e8961ed9d949e59d44cce5d10f
Gerrit-Change-Number: 18587
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 15:38:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Fix tar argument ordering to exclude .pyc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18587 )
Change subject: [tools] Fix tar argument ordering to exclude .pyc
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10690/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e344f2df6f27e8961ed9d949e59d44cce5d10f
Gerrit-Change-Number: 18587
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Jun 2022 23:06:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Fix tar argument ordering to exclude .pyc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18587 )
Change subject: [tools] Fix tar argument ordering to exclude .pyc
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e344f2df6f27e8961ed9d949e59d44cce5d10f
Gerrit-Change-Number: 18587
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 20:07:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Fix tar argument ordering to exclude .pyc
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18587 )
Change subject: [tools] Fix tar argument ordering to exclude .pyc
......................................................................
Patch Set 4:
That message really should've said BSD's, since I was running into it on Ubuntu. Oops.
--
To view, visit http://gerrit.cloudera.org:8080/18587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e344f2df6f27e8961ed9d949e59d44cce5d10f
Gerrit-Change-Number: 18587
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 20:58:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Fix tar argument ordering to exclude .pyc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18587 )
Change subject: [tools] Fix tar argument ordering to exclude .pyc
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8182/
--
To view, visit http://gerrit.cloudera.org:8080/18587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e344f2df6f27e8961ed9d949e59d44cce5d10f
Gerrit-Change-Number: 18587
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 09:37:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Fix tar argument ordering to exclude .pyc
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18587 )
Change subject: [tools] Fix tar argument ordering to exclude .pyc
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e344f2df6f27e8961ed9d949e59d44cce5d10f
Gerrit-Change-Number: 18587
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 04:59:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Fix tar argument ordering to exclude .pyc
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18587 )
Change subject: [tools] Fix tar argument ordering to exclude .pyc
......................................................................
[tools] Fix tar argument ordering to exclude .pyc
Moves `--exclude='*.pyc'` before the files to add as required by tar on
Debian. Fixes the message
> tar: --exclude ‘*.pyc’ has no effect
Change-Id: I79e344f2df6f27e8961ed9d949e59d44cce5d10f
Reviewed-on: http://gerrit.cloudera.org:8080/18587
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M shell/make_shell_tarball.sh
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I79e344f2df6f27e8961ed9d949e59d44cce5d10f
Gerrit-Change-Number: 18587
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] [tools] Fix tar argument ordering to exclude .pyc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18587 )
Change subject: [tools] Fix tar argument ordering to exclude .pyc
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8182/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e344f2df6f27e8961ed9d949e59d44cce5d10f
Gerrit-Change-Number: 18587
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 05:00:41 +0000
Gerrit-HasComments: No