You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "zwangsheng (via GitHub)" <gi...@apache.org> on 2023/03/23 03:32:51 UTC
[GitHub] [incubator-celeborn] zwangsheng commented on a diff in pull request #1373: [CELEBORN-345] TransportResponseHandler create too much thread
zwangsheng commented on code in PR #1373:
URL: https://github.com/apache/incubator-celeborn/pull/1373#discussion_r1145634785
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportResponseHandler.java:
##########
@@ -59,8 +60,10 @@ public class TransportResponseHandler extends MessageHandler<ResponseMessage> {
/** Records the time (in system nanoseconds) that the last fetch or RPC request was sent. */
private final AtomicLong timeOfLastRequestNs;
- private final ScheduledExecutorService pushTimeoutChecker;
private final long pushTimeoutCheckerInterval;
+ private static final ScheduledExecutorService pushTimeoutChecker =
+ ThreadUtils.newDaemonThreadPoolScheduledExecutor("push-timeout-checker-", 16);
Review Comment:
`push-timeout-checker- => push-timeout-checker`, we have added this splitter `-` in `newDaemonThreadPoolScheduledExecuto` function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org